From: Luis Chamberlain <mcgrof@kernel.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Boris Sukholitko <boris.sukholitko@broadcom.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, keescook@chromium.org,
yzaikin@google.com
Subject: Re: [PATCH] __register_sysctl_table: do not drop subdir
Date: Thu, 28 May 2020 14:20:45 +0000 [thread overview]
Message-ID: <20200528142045.GP11244@42.do-not-panic.com> (raw)
In-Reply-To: <874ks02m25.fsf@x220.int.ebiederm.org>
On Thu, May 28, 2020 at 09:04:02AM -0500, Eric W. Biederman wrote:
> I see some recent (within the last year) fixes to proc_sysctl.c in this
> area. Do you have those? It looks like bridge up and down is stressing
> this code. Either those most recent fixes are wrong, your kernel is
> missing them or this needs some more investigation.
Thanks for the review Eric.
Boris, the elaborate deatils you provided would also be what would be
needed for a commit log, specially since this is fixing a crash. If
you confirm this is still present upstream by reproducing with a test
case it would be wonderful.
If you are familiar with what might be the issue, you can even construct
your own kernel-code proof of concept test using lib/test_sysctl.c. We use the
script tools/testing/selftests/sysctl/sysctl.sh to hammer on that.
Luis
next prev parent reply other threads:[~2020-05-28 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 10:48 [PATCH] __register_sysctl_table: do not drop subdir Boris Sukholitko
2020-05-27 12:58 ` Luis Chamberlain
2020-05-28 8:08 ` Boris Sukholitko
2020-05-28 14:04 ` Eric W. Biederman
2020-05-28 14:20 ` Luis Chamberlain [this message]
2020-05-31 11:44 ` Boris Sukholitko
2020-06-01 13:17 ` Luis Chamberlain
2020-05-31 11:39 ` Boris Sukholitko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528142045.GP11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=boris.sukholitko@broadcom.com \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).