From: Jan Kara <jack@suse.cz>
To: Martijn Coenen <maco@android.com>
Cc: Jan Kara <jack@suse.cz>, Jaegeuk Kim <jaegeuk@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Jens Axboe <axboe@kernel.dk>,
miklos@szeredi.hu, tj@kernel.org, linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
kernel-team@android.com
Subject: Re: Writeback bug causing writeback stalls
Date: Mon, 1 Jun 2020 11:09:31 +0200 [thread overview]
Message-ID: <20200601090931.GA3960@quack2.suse.cz> (raw)
In-Reply-To: <CAB0TPYFuT7Gp=8qBCGBKa3O0=hkUMTZsmhn3VqZuoKYM4bZOSw@mail.gmail.com>
On Fri 29-05-20 21:37:50, Martijn Coenen wrote:
> Hi Jan,
>
> On Fri, May 29, 2020 at 5:20 PM Jan Kara <jack@suse.cz> wrote:
> > I understand. I have written a fix (attached). Currently its under testing
> > together with other cleanups. If everything works fine, I plan to submit
> > the patches on Monday.
>
> Thanks a lot for the quick fix! I ran my usual way to reproduce the
> problem, and did not see it, so that's good! I do observe write speed
> dips - eg we usually sustain 180 MB/s on this device, but now it
> regularly dips down to 10 MB/s, then jumps back up again. That might
> be unrelated to your patch though, I will run more tests over the
> weekend and report back!
Thanks for testing! My test run has completed fine so I'll submit patches
for review. But I'm curious what's causing the dips in throughput in your
test...
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2020-06-01 9:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 9:57 Writeback bug causing writeback stalls Martijn Coenen
2020-05-22 14:41 ` Jan Kara
2020-05-22 15:23 ` Martijn Coenen
2020-05-22 15:36 ` Jan Kara
2020-05-23 8:15 ` Martijn Coenen
2020-05-25 7:31 ` Jan Kara
2020-05-27 8:14 ` Martijn Coenen
2020-05-29 15:20 ` Jan Kara
2020-05-29 19:37 ` Martijn Coenen
2020-06-01 9:09 ` Jan Kara [this message]
2020-06-02 12:16 ` Martijn Coenen
[not found] ` <20200524140522.14196-1-hdanton@sina.com>
2020-05-25 7:38 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601090931.GA3960@quack2.suse.cz \
--to=jack@suse.cz \
--cc=axboe@kernel.dk \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=miklos@szeredi.hu \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).