From: Alexey Dobriyan <adobriyan@gmail.com>
To: axboe@kernel.dk
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
javier.gonz@samsung.com, linux-aio@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/3] io_uring: add support for zone-append
Date: Fri, 19 Jun 2020 18:22:08 +0300 [thread overview]
Message-ID: <20200619152208.GA62406@localhost.localdomain> (raw)
> uint64_t val = cqe->res; // assuming non-error here
>
> if (cqe->flags & IORING_CQE_F_ZONE_FOO)
> val |= (cqe->flags >> 16) << 32ULL;
Jens, ULL in shift doesn't do anything for widening the result.
You need
val |= (uint64_t)(cqe->flags >> 16) << 32;
next reply other threads:[~2020-06-19 15:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 15:22 Alexey Dobriyan [this message]
2020-06-19 15:23 ` [PATCH 3/3] io_uring: add support for zone-append Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2020-06-17 17:23 [PATCH 0/3] zone-append support in aio and io-uring Kanchan Joshi
[not found] ` <CGME20200617172713epcas5p352f2907a12bd4ee3c97be1c7d8e1569e@epcas5p3.samsung.com>
2020-06-17 17:23 ` [PATCH 3/3] io_uring: add support for zone-append Kanchan Joshi
2020-06-17 18:55 ` Pavel Begunkov
2020-06-18 7:39 ` Damien Le Moal
2020-06-18 8:35 ` javier.gonz@samsung.com
2020-06-18 8:47 ` Damien Le Moal
2020-06-18 9:11 ` javier.gonz@samsung.com
2020-06-19 9:41 ` javier.gonz@samsung.com
2020-06-19 11:15 ` Matias Bjørling
2020-06-19 14:18 ` Jens Axboe
2020-06-19 15:14 ` Matias Bjørling
2020-06-19 15:20 ` Jens Axboe
2020-06-19 15:40 ` Matias Bjørling
2020-06-19 15:44 ` Jens Axboe
2020-06-21 18:55 ` javier.gonz@samsung.com
2020-06-19 14:15 ` Jens Axboe
2020-06-19 14:59 ` Pavel Begunkov
2020-06-19 15:02 ` Jens Axboe
2020-06-21 18:52 ` javier.gonz@samsung.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619152208.GA62406@localhost.localdomain \
--to=adobriyan@gmail.com \
--cc=axboe@kernel.dk \
--cc=javier.gonz@samsung.com \
--cc=linux-aio@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).