From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3591DC433DF for ; Thu, 25 Jun 2020 01:25:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12C0E2078D for ; Thu, 25 Jun 2020 01:25:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="P1LfKqFc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389225AbgFYBZY (ORCPT ); Wed, 24 Jun 2020 21:25:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388928AbgFYBZX (ORCPT ); Wed, 24 Jun 2020 21:25:23 -0400 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F299DC061573; Wed, 24 Jun 2020 18:25:22 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 49sj4c29Z7z9sSt; Thu, 25 Jun 2020 11:25:20 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1593048321; bh=wZqYCZ4rzjYy8J0Uc//CISQWPwtAY2uNSf3i5tgRVVc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=P1LfKqFcSwtX9D0asb00y5WoSuSk2j7NvHv1XE/LT3TXlwVwM+gB8N8UpdgSojiA/ ZokR68IqW22ZB+xz7paQqsPkUENIOyCq4VFTy6IFUbUnKZrwKexu6J/W6lgOyLhZxh 8BhnXrFGNWvOJDQUrLu3DohcQa+Zv1dOMnYV7Li4rQ0Wo/NEwurKEIQdm/mEZVM24c aEbRSa1PUnRtLF63tmmkeCLZCSiQTfH/hJJaSkUj6fdi84kN5esGUxBo1URiEBMAR1 lgol+MoKlXXu5JX5A1ajBQF6zwwTiNcOKJ7V7eQj2eDhxSTXPJBT2PwEsnKkreYYye Z5p2zVngSmqgw== Date: Thu, 25 Jun 2020 11:25:17 +1000 From: Stephen Rothwell To: Qian Cai Cc: David Howells , Alexander Viro , linux-fsdevel@vger.kernel.org, LKML , Linux-Next Mailing List , paulmck@kernel.org, rcu@vger.kernel.org, torvalds@linux-foundation.org Subject: Re: Null-ptr-deref due to "vfs, fsinfo: Add an RCU safe per-ns mount list" Message-ID: <20200625112517.4cf8f3a9@canb.auug.org.au> In-Reply-To: <20200624155707.GA1259@lca.pw> References: <31941725-BEB0-4839-945A-4952C2B5ADC7@lca.pw> <2961585.1589326192@warthog.procyon.org.uk> <20200624155707.GA1259@lca.pw> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/t.bTb4R9aiObfQs2q7bZVl/"; protocol="application/pgp-signature"; micalg=pgp-sha256 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org --Sig_/t.bTb4R9aiObfQs2q7bZVl/ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi all, On Wed, 24 Jun 2020 11:57:07 -0400 Qian Cai wrote: > > On Wed, May 13, 2020 at 12:29:52AM +0100, David Howells wrote: > > Qian Cai wrote: > > =20 > > > Reverted the linux-next commit ee8ad8190cb1 (=E2=80=9Cvfs, fsinfo: Ad= d an RCU safe per-ns mount list=E2=80=9D) fixed the null-ptr-deref. =20 > >=20 > > Okay, I'm dropping this commit for now. =20 >=20 > What's the point of re-adding this buggy patch to linux-next again since > 0621 without fixing the previous reported issue at all? Reverting the > commit will still fix the crash below immediately, i.e., >=20 > dbc87e74d022 ("vfs, fsinfo: Add an RCU safe per-ns mount list") I have added a revert of that commit to linux-next today. --=20 Cheers, Stephen Rothwell --Sig_/t.bTb4R9aiObfQs2q7bZVl/ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl7z/P0ACgkQAVBC80lX 0GzqtggAhCC4k0Z3m35GbDRg7iW8yoeoyG5WHwIfVompDg7cqrbQs6XjVthYCghl B+/FDUDfo3wfGBy5PH1NdJRoZxwqYXWu69YvqA2jP+sNqDdsqu1uziKd2sDvthed FOEtxYWPYWQitRelIp2XF6T4K3wlsyP7nGZUUx987veQeL0Za8QFGln5LiGVywZr ZulkTHbDrMZBcDfUNjU4WHE1cVF0SfdwrknS7biVgJNtduBVVqCn3IVWJew3Z76R sv00DDNGe2FJiwvRPh48yXGjXLuDLFtJXnegEx2aojP8W/c09a5jsinmpnFRD70r O/xQWiHBqS8361DqqE09QtGStQFtpw== =/b6E -----END PGP SIGNATURE----- --Sig_/t.bTb4R9aiObfQs2q7bZVl/--