From: Matthew Wilcox <willy@infradead.org>
To: Ira Weiny <ira.weiny@intel.com>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/7] mm: Store compound_nr as well as compound_order
Date: Mon, 29 Jun 2020 17:24:05 +0100 [thread overview]
Message-ID: <20200629162405.GF25523@casper.infradead.org> (raw)
In-Reply-To: <20200629162227.GF2454695@iweiny-DESK2.sc.intel.com>
On Mon, Jun 29, 2020 at 09:22:27AM -0700, Ira Weiny wrote:
> On Mon, Jun 29, 2020 at 04:19:53PM +0100, Matthew Wilcox wrote:
> > static inline void set_compound_order(struct page *page, unsigned int order)
> > {
> > page[1].compound_order = order;
> > + page[1].compound_nr = 1U << order;
> ^^^
> 1UL?
>
> Ira
>
> > +++ b/include/linux/mm_types.h
> > @@ -134,6 +134,7 @@ struct page {
> > unsigned char compound_dtor;
> > unsigned char compound_order;
> > atomic_t compound_mapcount;
> > + unsigned int compound_nr; /* 1 << compound_order */
^^^^^^^^^^^^
No
next prev parent reply other threads:[~2020-06-29 18:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 15:19 [PATCH 0/7] THP prep patches Matthew Wilcox (Oracle)
2020-06-29 15:19 ` [PATCH 1/7] mm: Store compound_nr as well as compound_order Matthew Wilcox (Oracle)
2020-06-29 16:22 ` Ira Weiny
2020-06-29 16:24 ` Matthew Wilcox [this message]
2020-07-06 10:29 ` Kirill A. Shutemov
2020-08-11 22:53 ` Matthew Wilcox
2020-06-29 15:19 ` [PATCH 2/7] mm: Move page-flags include to top of file Matthew Wilcox (Oracle)
2020-06-29 15:19 ` [PATCH 3/7] mm: Add thp_order Matthew Wilcox (Oracle)
2020-06-29 15:19 ` [PATCH 4/7] mm: Add thp_size Matthew Wilcox (Oracle)
2020-06-29 15:19 ` [PATCH 5/7] mm: Replace hpage_nr_pages with thp_nr_pages Matthew Wilcox (Oracle)
2020-06-29 17:40 ` Mike Kravetz
2020-06-29 18:14 ` Matthew Wilcox
2020-06-29 18:32 ` Matthew Wilcox
2020-07-01 1:33 ` Andrew Morton
2020-06-29 15:19 ` [PATCH 6/7] mm: Add thp_head Matthew Wilcox (Oracle)
2020-06-29 15:19 ` [PATCH 7/7] mm: Introduce offset_in_thp Matthew Wilcox (Oracle)
2020-06-29 17:11 ` [PATCH 0/7] THP prep patches William Kucharski
2020-06-29 18:13 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629162405.GF25523@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=ira.weiny@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).