From: Alexey Dobriyan <adobriyan@gmail.com>
To: zhenwei pi <pizhenwei@bytedance.com>
Cc: tglx@linutronix.de, kzak@redhat.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs/proc: add short desc for /proc/softirqs
Date: Wed, 1 Jul 2020 21:14:36 +0300 [thread overview]
Message-ID: <20200701181436.GA100441@localhost.localdomain> (raw)
In-Reply-To: <1593614103-23574-1-git-send-email-pizhenwei@bytedance.com>
On Wed, Jul 01, 2020 at 10:35:03PM +0800, zhenwei pi wrote:
> Only softirq name is not friendly to end-users, typically 'HI' is
> difficult to understand. During developing irqtop/lsirq utilities
> for util-linux, Karel Zak considered that we should give more
> information to end-users. Discuss about this:
> https://github.com/karelzak/util-linux/pull/1079
>
> Add short desc for /proc/softirqs in this patch, then /proc/softirqs
> gets more human-readable.
> --- a/fs/proc/softirqs.c
> +++ b/fs/proc/softirqs.c
> @@ -20,7 +20,7 @@ static int show_softirqs(struct seq_file *p, void *v)
> seq_printf(p, "%12s:", softirq_to_name[i]);
> for_each_possible_cpu(j)
> seq_printf(p, " %10u", kstat_softirqs_cpu(i, j));
> - seq_putc(p, '\n');
> + seq_printf(p, " %s\n", softirq_to_desc[i]);
This could break parsers. I'd rather leave it as is and update proc(5).
Of course this file doesn't need more characters in it. :-\
prev parent reply other threads:[~2020-07-01 18:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 14:35 [PATCH] fs/proc: add short desc for /proc/softirqs zhenwei pi
2020-07-01 18:14 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701181436.GA100441@localhost.localdomain \
--to=adobriyan@gmail.com \
--cc=kzak@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pizhenwei@bytedance.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox