From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65D74C433E0 for ; Thu, 2 Jul 2020 13:51:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F13A2088E for ; Thu, 2 Jul 2020 13:51:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729368AbgGBNu5 (ORCPT ); Thu, 2 Jul 2020 09:50:57 -0400 Received: from verein.lst.de ([213.95.11.211]:44181 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728989AbgGBNu5 (ORCPT ); Thu, 2 Jul 2020 09:50:57 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 3C93A68AFE; Thu, 2 Jul 2020 15:50:54 +0200 (CEST) Date: Thu, 2 Jul 2020 15:50:54 +0200 From: Christoph Hellwig To: Miguel Ojeda Cc: Christoph Hellwig , Al Viro , Linus Torvalds , Luis Chamberlain , Matthew Wilcox , Kees Cook , Iurii Zaikin , linux-kernel , linux-fsdevel Subject: Re: [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read_iter Message-ID: <20200702135054.GA29240@lst.de> References: <20200701200951.3603160-1-hch@lst.de> <20200701200951.3603160-17-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jul 02, 2020 at 11:46:17AM +0200, Miguel Ojeda wrote: > Hi Christoph, > > On Wed, Jul 1, 2020 at 10:25 PM Christoph Hellwig wrote: > > > > Switch over all instances used directly as methods using these sed > > expressions: > > > > sed -i -e 's/\.read\(\s*=\s*\)seq_read/\.read_iter\1seq_read_iter/g' > > > > Signed-off-by: Christoph Hellwig > > Nit: the replacements don't take into account the spaces/tabs needed > to align the designated initializers. Do you have a suggestion for an automated replacement which does? I'll happily switch over to that.