Re: [PATCH v4 5/7] f2fs: support direct I/O with fscrypt using blk-crypto

Jaegeuk Kim
2020-07-21T20:11:45Z

On 07/20, Satya Tangirala wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Wire up f2fs with fscrypt direct I/O support. direct I/O with fscrypt is
> only supported through blk-crypto (i.e. CONFIG_BLK_INLINE_ENCRYPTION must
> have been enabled, the 'inlinecrypt' mount option must have been specified,
> and either hardware inline encryption support must be present or
> CONFIG_BLK_INLINE_ENCYRPTION_FALLBACK must have been enabled). Further,
> direct I/O on encrypted files is only supported when I/O is aligned
> to the filesystem block size (which is *not* necessarily the same as the
> block device's block size).
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> Co-developed-by: Satya Tangirala <satyat@google.com>
> Signed-off-by: Satya Tangirala <satyat@google.com>

Acked-by: Jaegeuk Kim <jaegeuk@kernel.org>

> ---
> fs/f2fs/f2fs.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index b35a50f4953c..978130b5a195 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -4082,7 +4082,11 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,
> struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
> int rw = iov_iter_rw(iter);
>
> - if (f2fs_post_read_required(inode))
> + if (!fscrypt_dio_supported(iocb, iter))
> + return true;
> + if (fsverity_active(inode))
> + return true;
> + if (f2fs_compressed_file(inode))
> return true;
> if (f2fs_is_multi_device(sbi))
> return true;
> --
> 2.28.0.rc0.105.gf9edc3c819-goog