From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82F0AC433EB for ; Mon, 27 Jul 2020 16:08:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 572F92073E for ; Mon, 27 Jul 2020 16:08:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Ith/WrXv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730712AbgG0QHy (ORCPT ); Mon, 27 Jul 2020 12:07:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726662AbgG0QHy (ORCPT ); Mon, 27 Jul 2020 12:07:54 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9DABC061794; Mon, 27 Jul 2020 09:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=z3qU3m6tsKDZPbT2vc9pt7LQranlA01CezSpjXDJxnM=; b=Ith/WrXv+lA5OkKjwFbOVJtWCg KhBjLIajyMpuKApHvBx5qTZNwGuRkbmFmWmQkHHDJrXY78/ky2fPxKBYNSVLjQgH+byriRENBU24o mdk0yUfSoIIgrr+uy31pGcP56rACOr5VSh4jrJyBb+Lc7rrPNQgQKE2M03tKiLZMR8LDIf5cqxqXp 9GxLRmwgcXtGYGqP6rElsSzdleZZaU6fuOUyyNDhuhn4upG2PWYmJEuABzTuihwS09QJXI3OwB8dz 8T+l5YLssd4OjjVdkvLvvriWSyQ0DVUkPSDMncIWv7F1BQKj57kKqMdY+SVBTaXQEzoZ1RShs8JN4 USWRWe8Q==; Received: from [2001:4bb8:18c:2acc:aa45:8411:1fb3:30ec] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1k05fK-0002mU-2r; Mon, 27 Jul 2020 16:07:51 +0000 From: Christoph Hellwig To: linux-kernel@vger.kernel.org Cc: Al Viro , Linus Torvalds , linux-fsdevel@vger.kernel.org, Marek Szyprowski Subject: [PATCH 1/3] initramfs: remove clean_rootfs Date: Mon, 27 Jul 2020 18:07:42 +0200 Message-Id: <20200727160744.329121-2-hch@lst.de> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200727160744.329121-1-hch@lst.de> References: <20200727160744.329121-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org There is no point in trying to clean up after unpacking the initramfs failed, as it should never get past the magic number check. In addition d_genocide is actually the wrong thing to do here, it should have been simple_recursive_remove(). Fixes: 38d014f6d446 ("initramfs: simplify clean_rootfs") Reported-by: Marek Szyprowski Signed-off-by: Christoph Hellwig --- init/initramfs.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/init/initramfs.c b/init/initramfs.c index 3823d15e5d2619..50ec7e3c5389aa 100644 --- a/init/initramfs.c +++ b/init/initramfs.c @@ -576,16 +576,6 @@ static inline bool kexec_free_initrd(void) #endif /* CONFIG_KEXEC_CORE */ #ifdef CONFIG_BLK_DEV_RAM -static void __init clean_rootfs(void) -{ - struct path path; - - if (kern_path("/", 0, &path)) - return; - d_genocide(path.dentry); - path_put(&path); -} - static void __init populate_initrd_image(char *err) { ssize_t written; @@ -625,7 +615,6 @@ static int __init populate_rootfs(void) err = unpack_to_rootfs((char *)initrd_start, initrd_end - initrd_start); if (err) { #ifdef CONFIG_BLK_DEV_RAM - clean_rootfs(); populate_initrd_image(err); #else printk(KERN_EMERG "Initramfs unpacking failed: %s\n", err); -- 2.27.0