* [PATCH] nilfs2: only call unlock_new_inode() if I_NEW
@ 2020-06-28 7:01 Eric Biggers
2020-07-27 16:50 ` Eric Biggers
0 siblings, 1 reply; 3+ messages in thread
From: Eric Biggers @ 2020-06-28 7:01 UTC (permalink / raw)
To: linux-nilfs, Ryusuke Konishi; +Cc: linux-fsdevel, linux-kernel
From: Eric Biggers <ebiggers@google.com>
unlock_new_inode() is only meant to be called after a new inode has
already been inserted into the hash table. But nilfs_new_inode() can
call it even before it has inserted the inode, triggering the WARNING in
unlock_new_inode(). Fix this by only calling unlock_new_inode() if the
inode has the I_NEW flag set, indicating that it's in the table.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/nilfs2/inode.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/nilfs2/inode.c b/fs/nilfs2/inode.c
index 28009ec54420..3318dd1350b2 100644
--- a/fs/nilfs2/inode.c
+++ b/fs/nilfs2/inode.c
@@ -388,7 +388,8 @@ struct inode *nilfs_new_inode(struct inode *dir, umode_t mode)
failed_after_creation:
clear_nlink(inode);
- unlock_new_inode(inode);
+ if (inode->i_state & I_NEW)
+ unlock_new_inode(inode);
iput(inode); /*
* raw_inode will be deleted through
* nilfs_evict_inode().
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nilfs2: only call unlock_new_inode() if I_NEW
2020-06-28 7:01 [PATCH] nilfs2: only call unlock_new_inode() if I_NEW Eric Biggers
@ 2020-07-27 16:50 ` Eric Biggers
2020-07-27 16:59 ` Ryusuke Konishi
0 siblings, 1 reply; 3+ messages in thread
From: Eric Biggers @ 2020-07-27 16:50 UTC (permalink / raw)
To: linux-nilfs, Ryusuke Konishi; +Cc: linux-fsdevel, linux-kernel
On Sun, Jun 28, 2020 at 12:01:52AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> unlock_new_inode() is only meant to be called after a new inode has
> already been inserted into the hash table. But nilfs_new_inode() can
> call it even before it has inserted the inode, triggering the WARNING in
> unlock_new_inode(). Fix this by only calling unlock_new_inode() if the
> inode has the I_NEW flag set, indicating that it's in the table.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Ping. Ryusuke, any interest in taking this patch?
- Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nilfs2: only call unlock_new_inode() if I_NEW
2020-07-27 16:50 ` Eric Biggers
@ 2020-07-27 16:59 ` Ryusuke Konishi
0 siblings, 0 replies; 3+ messages in thread
From: Ryusuke Konishi @ 2020-07-27 16:59 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-nilfs, linux-fsdevel, LKML
Yeah, I sent this to Andrew a little while ago:
https://lkml.org/lkml/2020/7/27/976
Thanks,
Ryusuke Konishi
On Tue, Jul 28, 2020 at 1:50 AM Eric Biggers <ebiggers@kernel.org> wrote:
>
> On Sun, Jun 28, 2020 at 12:01:52AM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > unlock_new_inode() is only meant to be called after a new inode has
> > already been inserted into the hash table. But nilfs_new_inode() can
> > call it even before it has inserted the inode, triggering the WARNING in
> > unlock_new_inode(). Fix this by only calling unlock_new_inode() if the
> > inode has the I_NEW flag set, indicating that it's in the table.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
>
> Ping. Ryusuke, any interest in taking this patch?
>
> - Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-27 16:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-28 7:01 [PATCH] nilfs2: only call unlock_new_inode() if I_NEW Eric Biggers
2020-07-27 16:50 ` Eric Biggers
2020-07-27 16:59 ` Ryusuke Konishi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).