From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB523C433E0 for ; Mon, 3 Aug 2020 16:34:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87E3E20792 for ; Mon, 3 Aug 2020 16:34:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ZX1YfeI+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726643AbgHCQeq (ORCPT ); Mon, 3 Aug 2020 12:34:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbgHCQep (ORCPT ); Mon, 3 Aug 2020 12:34:45 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CF53C06174A; Mon, 3 Aug 2020 09:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=16ecIfKYTC6wA0DdewyyTEigHELGFn55FwwngqqMb48=; b=ZX1YfeI+UTqupGHYcevoIHrxnX S99QlFQhbTDmeGpKj+bDeoA9VVtzf+xI02TbV/C1JyQuYz8CEdH3NeOAaRfohAxcO9vIiFJmIxGLx +f31Ws3bI2wpDkWLsWKit3Vega/7/vwgl7kN5jiTZaYeSaIsvfYE+vdqWqUZrSnTCr2ZzD+SjEFRt AczXQuwbJDucOp/L17S5/yFNAhbN9YnNm3S39i8+2YyBiuOI1WiVojYJK+rnEYMGRbyPwFWT//mXo b9/unNrPWJMJovAz5l1cxHtnQoVZk6fF1mv6pltctOjb8fzvChuERjpiKpUb0pXZM2RfvUQFH5+Es Py+ysuBQ==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2dPx-0003zS-JQ; Mon, 03 Aug 2020 16:34:29 +0000 Date: Mon, 3 Aug 2020 17:34:29 +0100 From: Christoph Hellwig To: Kalesh Singh Cc: Jonathan Corbet , Sumit Semwal , Alexander Viro , Steven Rostedt , Ingo Molnar , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-fsdevel@vger.kernel.org, Suren Baghdasaryan , Hridya Valsaraju , Ioannis Ilkos , John Stultz , kernel-team@android.com Subject: Re: [PATCH 1/2] fs: Add fd_install file operation Message-ID: <20200803163429.GA15200@infradead.org> References: <20200803144719.3184138-1-kaleshsingh@google.com> <20200803144719.3184138-2-kaleshsingh@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200803144719.3184138-2-kaleshsingh@google.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Aug 03, 2020 at 02:47:18PM +0000, Kalesh Singh wrote: > Provides a per process hook for the acquisition of file descriptors, > despite the method used to obtain the descriptor. > > Signed-off-by: Kalesh Singh I strongly disagree with this. The file operation has no business hooking into installing the fd.