From: "Darrick J. Wong" <djwong@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
david@fromorbit.com, linux-kernel@vger.kernel.org,
sandeen@sandeen.net, hch@lst.de,
linux-ext4 <linux-ext4@vger.kernel.org>,
Theodore Ts'o <tytso@mit.edu>,
riteshh@linux.ibm.com, rgoldwyn@suse.de, agruenba@redhat.com,
linux-btrfs@vger.kernel.org
Subject: [GIT PULL v2] iomap: new code for 5.9-rc1
Date: Thu, 6 Aug 2020 08:07:43 -0700 [thread overview]
Message-ID: <20200806150743.GC6090@magnolia> (raw)
Hi Linus,
Please pull these new changes to the iomap code for 5.9. The most
notable changes are:
1) iomap no longer invalidate the page cache when performing a direct
read, since doing so is unnecessary and the old directio code doesn't do
that either.
2) iomap embraced the use of returning ENOTBLK from a direct write to
trigger falling back to a buffered write since ext4 already did this and
btrfs wants it for their port.
3) iomap falls back to buffered writes if we're doing a direct write and
the page cache invalidation after the flush fails; this was necessary to
handle a corner case in the btrfs port.
4) Remove email virus scanner detritus that was accidentally included in
yesterday's pull request. Clearly I need(ed) to update my git branch
checker scripts. :(
The branch merges cleanly with your HEAD branch as of a few minutes ago.
Please let me know if there are any strange problems.
--D
The following changes since commit dcb7fd82c75ee2d6e6f9d8cc71c52519ed52e258:
Linux 5.8-rc4 (2020-07-05 16:20:22 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/iomap-5.9-merge-5
for you to fetch changes up to 60263d5889e6dc5987dc51b801be4955ff2e4aa7:
iomap: fall back to buffered writes for invalidation failures (2020-08-05 09:24:16 -0700)
----------------------------------------------------------------
New code for 5.9:
- Make sure we call ->iomap_end with a failure code if ->iomap_begin
failed in any way; some filesystems need to try to undo things.
- Don't invalidate the page cache during direct reads since we already
sync'd the cache with disk.
- Make direct writes fall back to the page cache if the pre-write
cache invalidation fails. This avoids a cache coherency problem.
- Fix some idiotic virus scanner warning bs in the previous tag.
----------------------------------------------------------------
Andreas Gruenbacher (1):
iomap: Make sure iomap_end is called after iomap_begin
Christoph Hellwig (2):
xfs: use ENOTBLK for direct I/O to buffered I/O fallback
iomap: fall back to buffered writes for invalidation failures
Dave Chinner (1):
iomap: Only invalidate page cache pages on direct IO writes
fs/ext4/file.c | 2 ++
fs/gfs2/file.c | 3 ++-
fs/iomap/apply.c | 13 +++++++++----
fs/iomap/direct-io.c | 37 +++++++++++++++++++++----------------
fs/iomap/trace.h | 1 +
fs/xfs/xfs_file.c | 8 ++++----
fs/zonefs/super.c | 7 +++++--
7 files changed, 44 insertions(+), 27 deletions(-)
next reply other threads:[~2020-08-06 17:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 15:07 Darrick J. Wong [this message]
2020-08-07 2:39 ` [GIT PULL v2] iomap: new code for 5.9-rc1 pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806150743.GC6090@magnolia \
--to=djwong@kernel.org \
--cc=agruenba@redhat.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rgoldwyn@suse.de \
--cc=riteshh@linux.ibm.com \
--cc=sandeen@sandeen.net \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).