From: Matthew Wilcox <willy@infradead.org>
To: "Burrow, Ryan - 0553 - MITLL" <Ryan.Burrow@ll.mit.edu>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Bug fix to ELF Loader which rejects valid ELFs
Date: Tue, 11 Aug 2020 16:05:17 +0100 [thread overview]
Message-ID: <20200811150517.GR17456@casper.infradead.org> (raw)
In-Reply-To: <c51feef9afbd4b82a3c718a072433a20@ll.mit.edu>
On Tue, Aug 11, 2020 at 02:44:08PM +0000, Burrow, Ryan - 0553 - MITLL wrote:
> /* Sanity check the number of program headers... */
> - /* ...and their total size. */
> - size = sizeof(struct elf_phdr) * elf_ex->e_phnum;
> - if (size == 0 || size > 65536 || size > ELF_MIN_ALIGN)
> + if (elf_ex->e_phnum == 0 || elf_ex->phnum > 65535)
umm, did you compile-test this?
assuming you meant e_phnum, it's a 16-bit quantity, so it can't be bigger
than 65535.
> goto out;
>
> + size = sizeof(struct elf_phdr) * elf_ex->e_phnum;
use array_size() here?
next prev parent reply other threads:[~2020-08-11 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 14:44 [PATCH] Bug fix to ELF Loader which rejects valid ELFs Burrow, Ryan - 0553 - MITLL
2020-08-11 15:05 ` Matthew Wilcox [this message]
2020-08-11 16:39 ` Burrow, Ryan - 0553 - MITLL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811150517.GR17456@casper.infradead.org \
--to=willy@infradead.org \
--cc=Ryan.Burrow@ll.mit.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox