From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55786C433DF for ; Tue, 18 Aug 2020 13:40:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C9FD206B5 for ; Tue, 18 Aug 2020 13:40:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Mrb3gBgP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726731AbgHRNkk (ORCPT ); Tue, 18 Aug 2020 09:40:40 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:37007 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726636AbgHRNki (ORCPT ); Tue, 18 Aug 2020 09:40:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597758037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LXWmYAEPDvHrYOWUrEhJYqbCxad+Oxs8vtQSuseqfi8=; b=Mrb3gBgP9FKsOeUbQxMOHZFagcWJvXr7nRATLi2KH2RVg8JVdhLmBk1u9e0GyElwZ+p9OP /wEz1DGx392U7U+OxE7rLOJz8RFDGXR6em43SjPimVKuqP9BTdcF2S8NX3mjhQTniA6G5l a7ACKBrwj1ZUHl8TBywPPX2COVg3JbE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-318-VyxC6xixMB26SP9NZten_g-1; Tue, 18 Aug 2020 09:40:35 -0400 X-MC-Unique: VyxC6xixMB26SP9NZten_g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B3EF21006701; Tue, 18 Aug 2020 13:40:33 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.192.59]) by smtp.corp.redhat.com (Postfix) with SMTP id E20C65C1DC; Tue, 18 Aug 2020 13:40:29 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 18 Aug 2020 15:40:33 +0200 (CEST) Date: Tue, 18 Aug 2020 15:40:28 +0200 From: Oleg Nesterov To: Jann Horn Cc: Andrew Morton , Linus Torvalds , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Alexander Viro , "Eric W . Biederman" Subject: Re: [PATCH v3 2/5] coredump: Let dump_emit() bail out on short writes Message-ID: <20200818134027.GF29865@redhat.com> References: <20200818061239.29091-1-jannh@google.com> <20200818061239.29091-3-jannh@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200818061239.29091-3-jannh@google.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 08/18, Jann Horn wrote: > > + if (dump_interrupted()) > + return 0; > + n = __kernel_write(file, addr, nr, &pos); > + if (n != nr) > + return 0; > + file->f_pos = pos; Just curious, can't we simply do __kernel_write(file, addr, nr, &file->f_pos); and avoid "loff_t pos" ? Oleg.