From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
"yukuai (C)" <yukuai3@huawei.com>,
Gao Xiang <hsiangkao@redhat.com>,
darrick.wong@oracle.com, david@fromorbit.com,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, yi.zhang@huawei.com
Subject: Re: [RFC PATCH V3] iomap: add support to track dirty state of sub pages
Date: Sat, 22 Aug 2020 17:43:34 +0100 [thread overview]
Message-ID: <20200822164334.GA2625@infradead.org> (raw)
In-Reply-To: <20200822142414.GY17456@casper.infradead.org>
On Sat, Aug 22, 2020 at 03:24:14PM +0100, Matthew Wilcox wrote:
> The case I was worrying about:
>
> fill a filesystem so that free space is very fragmented
> readahead into a hole
> hole is large, don't allocate an iop
> writeback the page
> don't have an iop, can't track the write count
>
> I'd be fine with choosing to allocate an iop later (and indeed I do that
> as part of the THP work). But does this scenario make you think of any
> other corner cases?
Can't think of a corner case. And as said last time this comes up I
think trying to allocate the iop as late and lazy as possible is
probably a good thing. I just went for the dumb way because it was
simpler and already a huge improvement over buffer heads.
next prev parent reply other threads:[~2020-08-22 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 12:05 [RFC PATCH V3] iomap: add support to track dirty state of sub pages Yu Kuai
2020-08-19 12:56 ` Gao Xiang
2020-08-20 1:38 ` yukuai (C)
2020-08-21 6:12 ` Christoph Hellwig
2020-08-21 13:36 ` Matthew Wilcox
2020-08-22 6:03 ` Christoph Hellwig
2020-08-22 14:24 ` Matthew Wilcox
2020-08-22 16:43 ` Christoph Hellwig [this message]
2020-08-21 6:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200822164334.GA2625@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hsiangkao@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox