From: Ross Zwisler <zwisler@google.com>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org,
Mattias Nissler <mnissler@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Benjamin Gordon <bmgordon@google.com>,
David Howells <dhowells@redhat.com>,
Dmitry Torokhov <dtor@google.com>,
Jesse Barnes <jsbarnes@google.com>,
linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Micah Morton <mortonm@google.com>,
Raul Rangel <rrangel@google.com>, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v8 1/2] Add a "nosymfollow" mount option.
Date: Thu, 27 Aug 2020 10:48:57 -0600 [thread overview]
Message-ID: <20200827164857.GA414369@google.com> (raw)
In-Reply-To: <20200827154139.vwuflrlvj257krnw@yavin.dot.cyphar.com>
On Fri, Aug 28, 2020 at 01:41:39AM +1000, Aleksa Sarai wrote:
> On 2020-08-27, Al Viro <viro@zeniv.linux.org.uk> wrote:
> > On Wed, Aug 26, 2020 at 02:48:19PM -0600, Ross Zwisler wrote:
> >
> > > Al, now that the changes to fs/namei.c have landed and we're past the merge
> > > window for v5.9, what are your thoughts on this patch and the associated test?
> >
> > Humm... should that be nd->path.mnt->mnt_flags or link->mnt->mnt_flags?
> > Usually it's the same thing, but they might differ. IOW, is that about the
> > directory we'd found it in, or is it about the link itself?
>
> Now that you mention it, I think link->mnt->mnt_flags makes more sense.
> The restriction should apply in the context of whatever filesystem
> contains the symlink, and that would matches FreeBSD's semantics (at
> least as far as I can tell from a quick look at sys/kern/vfs_lookup.c).
Yep, changing this to link->mnt->mnt_flags makes sense to me, as you're right
that we care about the link itself and not the link's parent directory. Thank
you for the review, and I'll send out v9 momentarily.
prev parent reply other threads:[~2020-08-27 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 16:43 [PATCH v8 1/2] Add a "nosymfollow" mount option Ross Zwisler
2020-08-19 16:43 ` [PATCH v8 2/2] selftests: mount: add nosymfollow tests Ross Zwisler
2020-08-26 20:48 ` [PATCH v8 1/2] Add a "nosymfollow" mount option Ross Zwisler
2020-08-27 1:59 ` Al Viro
2020-08-27 15:41 ` Aleksa Sarai
2020-08-27 16:48 ` Ross Zwisler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827164857.GA414369@google.com \
--to=zwisler@google.com \
--cc=akpm@linux-foundation.org \
--cc=bmgordon@google.com \
--cc=cyphar@cyphar.com \
--cc=dhowells@redhat.com \
--cc=dtor@google.com \
--cc=jsbarnes@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mnissler@chromium.org \
--cc=mortonm@google.com \
--cc=rrangel@google.com \
--cc=shuah@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).