From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56C76C43461 for ; Mon, 7 Sep 2020 07:07:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17496207C3 for ; Mon, 7 Sep 2020 07:07:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="SFA/iSjW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726771AbgIGHHL (ORCPT ); Mon, 7 Sep 2020 03:07:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726384AbgIGHHJ (ORCPT ); Mon, 7 Sep 2020 03:07:09 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 378F7C061573; Mon, 7 Sep 2020 00:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Rd5+BO+wcfvR2DH9JGUePavDycNE1Fegbtj9haaWlK8=; b=SFA/iSjWCUlVdK5O159w5509yb zfZBUgtaaXJV8db/l4c7rEYPRVV6aDFq6ZH3ycehB74S7efqOeXM7svGVnwWSxWZPX48LHIBjYtg6 5UH0ePFHEKrdFfLrlCV85rakArCUCcC6M6cxwQsIFTiQBwKEEREaaqhENLGAZwxJcqaXUj3OgnbPr Jp4fEjLAmS2bCuzJUYOFYx/acz69sIkgUdQhazDxp5xetBKYRECY8/J2Xq6awZc7K6WJQOcK91Cm/ E9hMxkdNzTXysqw2YnKVBkHAtLWRLUUw7Cuj3d6+DlsGk12SkO3VS5dfXguTOvhgAR+6jYsM7GCVF 3BtbueOg==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFBEz-00073a-HM; Mon, 07 Sep 2020 07:07:01 +0000 Date: Mon, 7 Sep 2020 08:07:01 +0100 From: Christoph Hellwig To: Andreas Gruenbacher Cc: Christoph Hellwig , "Darrick J. Wong" , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cluster-devel@redhat.com Subject: Re: [PATCH] iomap: Fix direct I/O write consistency check Message-ID: <20200907070701.GA27019@infradead.org> References: <20200903165632.1338996-1-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200903165632.1338996-1-agruenba@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Sep 03, 2020 at 06:56:32PM +0200, Andreas Gruenbacher wrote: > When a direct I/O write falls back to buffered I/O entirely, dio->size > will be 0 in iomap_dio_complete. Function invalidate_inode_pages2_range > will try to invalidate the rest of the address space. If there are any > dirty pages in that range, the write will fail and a "Page cache > invalidation failure on direct I/O" error will be logged. Looks good, Reviewed-by: Christoph Hellwig