From: Matthew Wilcox <willy@infradead.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Xiaoming Ni <nixiaoming@huawei.com>, Jan Kara <jack@suse.cz>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
wangle6@huawei.com
Subject: Re: Question: Why is there no notification when a file is opened using filp_open()?
Date: Tue, 8 Sep 2020 18:18:59 +0100 [thread overview]
Message-ID: <20200908171859.GA29953@casper.infradead.org> (raw)
In-Reply-To: <CAOQ4uxgvodepq2ZhmGEpkZYj017tH_pk2AgV=pUhWiONnxOQjw@mail.gmail.com>
On Tue, Sep 08, 2020 at 04:18:29PM +0300, Amir Goldstein wrote:
> On Tue, Sep 8, 2020 at 3:53 PM Xiaoming Ni <nixiaoming@huawei.com> wrote:
> > For example, in fs/coredump.c, do_coredump() calls filp_open() to
> > generate core files.
> > In this scenario, the fsnotify_open() notification is missing.
>
> I am not convinced that we should generate an event.
> You will have to explain in what is the real world use case that requires this
> event to be generated.
Take the typical usage for fsnotify of a graphical file manager.
It would be nice if the file manager showed a corefile as soon as it
appeared in a directory rather than waiting until some other operation
in that directory caused those directory contents to be refreshed.
next prev parent reply other threads:[~2020-09-08 17:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 8:01 Question: Why is there no notification when a file is opened using filp_open()? Xiaoming Ni
2020-09-08 10:06 ` Amir Goldstein
2020-09-08 12:53 ` Xiaoming Ni
2020-09-08 13:18 ` Amir Goldstein
2020-09-08 17:18 ` Matthew Wilcox [this message]
2020-09-09 3:44 ` Amir Goldstein
2020-09-09 6:59 ` Xiaoming Ni
2020-09-09 7:36 ` Amir Goldstein
2020-09-09 11:11 ` Jan Kara
2020-09-09 16:03 ` Amir Goldstein
2020-09-10 8:14 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908171859.GA29953@casper.infradead.org \
--to=willy@infradead.org \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=wangle6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).