Re: [PATCH] iomap: Use round_down/round_up macros in __iomap_write_begin

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Thu, Sep 10, 2020 at 03:47:43PM +0300, Nikolay Borisov wrote:
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Looks ok to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  fs/iomap/buffered-io.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index bcfc288dba3f..31eb680d8c64 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -571,8 +571,8 @@ __iomap_write_begin(struct inode *inode, loff_t pos, unsigned len, int flags,
>  {
>  	struct iomap_page *iop = iomap_page_create(inode, page);
>  	loff_t block_size = i_blocksize(inode);
> -	loff_t block_start = pos & ~(block_size - 1);
> -	loff_t block_end = (pos + len + block_size - 1) & ~(block_size - 1);
> +	loff_t block_start = round_down(pos, block_size);
> +	loff_t block_end = round_up(pos + len, block_size);
>  	unsigned from = offset_in_page(pos), to = from + len, poff, plen;
>  	int status;
>  
> -- 
> 2.17.1
>