From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-fsdevel@vger.kernel.org,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Bill O'Donnell <billodo@redhat.com>
Subject: [PATCH] fs: Support THPs in vfs_dedupe_file_range
Date: Tue, 15 Sep 2020 15:46:16 +0100 [thread overview]
Message-ID: <20200915144616.27288-1-willy@infradead.org> (raw)
We may get tail pages returned from vfs_dedupe_get_page(). If we do,
we have to call page_mapping() instead of dereferencing page->mapping
directly. We may also deadlock trying to lock the page twice if they're
subpages of the same THP, so compare the head pages instead.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
fs/read_write.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/fs/read_write.c b/fs/read_write.c
index 5db58b8c78d0..c4d5eb47a21e 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -1906,6 +1906,8 @@ static struct page *vfs_dedupe_get_page(struct inode *inode, loff_t offset)
*/
static void vfs_lock_two_pages(struct page *page1, struct page *page2)
{
+ page1 = thp_head(page1);
+ page2 = thp_head(page2);
/* Always lock in order of increasing index. */
if (page1->index > page2->index)
swap(page1, page2);
@@ -1918,6 +1920,8 @@ static void vfs_lock_two_pages(struct page *page1, struct page *page2)
/* Unlock two pages, being careful not to unlock the same page twice. */
static void vfs_unlock_two_pages(struct page *page1, struct page *page2)
{
+ page1 = thp_head(page1);
+ page2 = thp_head(page2);
unlock_page(page1);
if (page1 != page2)
unlock_page(page2);
@@ -1972,8 +1976,8 @@ static int vfs_dedupe_file_range_compare(struct inode *src, loff_t srcoff,
* someone is invalidating pages on us and we lose.
*/
if (!PageUptodate(src_page) || !PageUptodate(dest_page) ||
- src_page->mapping != src->i_mapping ||
- dest_page->mapping != dest->i_mapping) {
+ page_mapping(src_page) != src->i_mapping ||
+ page_mapping(dest_page) != dest->i_mapping) {
same = false;
goto unlock;
}
--
2.28.0
next reply other threads:[~2020-09-15 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 14:46 Matthew Wilcox (Oracle) [this message]
2020-09-15 16:38 ` [PATCH] fs: Support THPs in vfs_dedupe_file_range Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915144616.27288-1-willy@infradead.org \
--to=willy@infradead.org \
--cc=billodo@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).