From: Tom Hromatka <tom.hromatka@oracle.com>
To: tom.hromatka@oracle.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, fweisbec@gmail.com,
tglx@linutronix.de, mingo@kernel.org, adobriyan@gmail.com
Subject: [PATCH v2 1/2] tick-sched: Do not clear the iowait and idle times
Date: Tue, 15 Sep 2020 13:36:26 -0600 [thread overview]
Message-ID: <20200915193627.85423-2-tom.hromatka@oracle.com> (raw)
In-Reply-To: <20200915193627.85423-1-tom.hromatka@oracle.com>
Prior to this commit, the cpu idle and iowait data in /proc/stat were
cleared when a CPU goes down. When the CPU came back online, both idle
and iowait times were restarted from 0.
This commit preserves the CPU's idle and iowait values when a CPU goes
offline and comes back online.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
---
kernel/time/tick-sched.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index f0199a4ba1ad..4fbf67171dde 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -1383,13 +1383,22 @@ void tick_setup_sched_timer(void)
void tick_cancel_sched_timer(int cpu)
{
struct tick_sched *ts = &per_cpu(tick_cpu_sched, cpu);
+ ktime_t idle_sleeptime, iowait_sleeptime;
# ifdef CONFIG_HIGH_RES_TIMERS
if (ts->sched_timer.base)
hrtimer_cancel(&ts->sched_timer);
# endif
+ /*
+ * Preserve idle and iowait sleep times accross a CPU offline/online
+ * sequence as they are accumulative.
+ */
+ idle_sleeptime = ts->idle_sleeptime;
+ iowait_sleeptime = ts->iowait_sleeptime;
memset(ts, 0, sizeof(*ts));
+ ts->idle_sleeptime = idle_sleeptime;
+ ts->iowait_sleeptime = iowait_sleeptime;
}
#endif
--
2.25.4
next prev parent reply other threads:[~2020-09-15 19:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 19:36 [PATCH v2 0/2] iowait and idle fixes in /proc/stat Tom Hromatka
2020-09-15 19:36 ` Tom Hromatka [this message]
2020-09-24 20:41 ` [PATCH v2 1/2] tick-sched: Do not clear the iowait and idle times Thomas Gleixner
2020-09-15 19:36 ` [PATCH v2 2/2] /proc/stat: Simplify iowait and idle calculations when cpu is offline Tom Hromatka
2020-09-24 21:19 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915193627.85423-2-tom.hromatka@oracle.com \
--to=tom.hromatka@oracle.com \
--cc=adobriyan@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).