From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FFACC43461 for ; Wed, 16 Sep 2020 23:12:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3504D22208 for ; Wed, 16 Sep 2020 23:12:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726744AbgIPXMS (ORCPT ); Wed, 16 Sep 2020 19:12:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726610AbgIPXMK (ORCPT ); Wed, 16 Sep 2020 19:12:10 -0400 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BE4DC06174A for ; Wed, 16 Sep 2020 16:12:10 -0700 (PDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIgaq-00039C-4W; Wed, 16 Sep 2020 23:12:04 +0000 Date: Thu, 17 Sep 2020 00:12:04 +0100 From: Al Viro To: Alexey Dobriyan Cc: linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fs: fix cast in fsparam_u32hex() macro Message-ID: <20200916231204.GM3421308@ZenIV.linux.org.uk> References: <20200916201843.GA802551@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200916201843.GA802551@localhost.localdomain> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Sep 16, 2020 at 11:18:43PM +0300, Alexey Dobriyan wrote: > Signed-off-by: Alexey Dobriyan > --- > > include/linux/fs_parser.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/include/linux/fs_parser.h > +++ b/include/linux/fs_parser.h > @@ -120,7 +120,7 @@ static inline bool fs_validate_description(const char *name, > #define fsparam_u32oct(NAME, OPT) \ > __fsparam(fs_param_is_u32, NAME, OPT, 0, (void *)8) > #define fsparam_u32hex(NAME, OPT) \ > - __fsparam(fs_param_is_u32_hex, NAME, OPT, 0, (void *16)) > + __fsparam(fs_param_is_u32_hex, NAME, OPT, 0, (void *)16) > #define fsparam_s32(NAME, OPT) __fsparam(fs_param_is_s32, NAME, OPT, 0, NULL) > #define fsparam_u64(NAME, OPT) __fsparam(fs_param_is_u64, NAME, OPT, 0, NULL) > #define fsparam_enum(NAME, OPT, array) __fsparam(fs_param_is_enum, NAME, OPT, 0, array) Nice catch; applied.