From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37236C2D0E2 for ; Thu, 24 Sep 2020 16:36:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5DE72396E for ; Thu, 24 Sep 2020 16:36:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="WaZgps9x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727003AbgIXQgh (ORCPT ); Thu, 24 Sep 2020 12:36:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726477AbgIXQgh (ORCPT ); Thu, 24 Sep 2020 12:36:37 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83230C0613CE; Thu, 24 Sep 2020 09:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jfjkeIZEHhA3nRGodYuDZGJpWjSMB63Yuv7NgD+cErM=; b=WaZgps9xKsu6rbYiNvGx72oTrv vVewECLFfimVgWA/2LFj/ydxsOkaeQI1Iym0nCniHXumNWyYBvXeodqg1wwPqcurBDUdCHIKPizYE nNSxiq+MjuJhVql+7N87UscvrHzIRWMXFE77X6qxMmBuyl4mCJlBuvYQZgdf0Gv0saEdCIieeFfNQ V93KHyAytumfQtyA7bW5M12T6K6PICZyacexU5w7lWmzVYzMoiXRapQtHZ0lyiad+Xp/x6/K/a/sq KVNIyrC63edZp903p1YY56aiIf86lT4m85ZrI0eDFM1+IWGhD8FuMlg40ulCWzErXWZf6RMOLKGTe BdZHBfAA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLUEV-0005hf-Dd; Thu, 24 Sep 2020 16:36:35 +0000 Date: Thu, 24 Sep 2020 17:36:35 +0100 From: Matthew Wilcox To: Sedat Dilek Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J. Wong" , Christoph Hellwig , Qian Cai , Brian Foster Subject: Re: [PATCH] iomap: Set all uptodate bits for an Uptodate page Message-ID: <20200924163635.GZ32101@casper.infradead.org> References: <20200924125608.31231-1-willy@infradead.org> <20200924151538.GW32101@casper.infradead.org> <20200924152755.GY32101@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Sep 24, 2020 at 06:19:03PM +0200, Sedat Dilek wrote: > On Thu, Sep 24, 2020 at 5:27 PM Matthew Wilcox wrote: > > > > On Thu, Sep 24, 2020 at 05:21:00PM +0200, Sedat Dilek wrote: > > > Great and thanks. > > > > > > Can you send out a seperate patch and label it with "PATCH v5.9"? > > > I run: > > > $ git format-patch -1 --subject-prefix="PATCH v5.9" --signoff > > > > > > Normally, I catch patches from any patchwork URL in mbox format. > > > > Maybe wait a few hours for people to decide if they like the approach > > taken to fix the bug before diving into producing backports? > > That make sense. > > You have a test-case for me? > I have here Linux-Test-Project and FIO available. Qian reported preadv203.c could reproduce it easily on POWER and ARM. They have 64kB pages, so it's easier to hit. You need to have a filesystem with block size < page size to hit the problem. If you want to check that your test case hits the problem, stick a printk in iomap_page_create().