From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E3E4C2D0A8 for ; Sat, 26 Sep 2020 14:46:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BB8D21D7F for ; Sat, 26 Sep 2020 14:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729371AbgIZOq1 (ORCPT ); Sat, 26 Sep 2020 10:46:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726210AbgIZOq1 (ORCPT ); Sat, 26 Sep 2020 10:46:27 -0400 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 511FAC0613CE for ; Sat, 26 Sep 2020 07:46:27 -0700 (PDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMBSv-006gVF-5T; Sat, 26 Sep 2020 14:46:21 +0000 Date: Sat, 26 Sep 2020 15:46:21 +0100 From: Al Viro To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 4/4] fs: simplify vfs_path_lookup Message-ID: <20200926144621.GY3421308@ZenIV.linux.org.uk> References: <20200926092051.115577-1-hch@lst.de> <20200926092051.115577-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200926092051.115577-5-hch@lst.de> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, Sep 26, 2020 at 11:20:51AM +0200, Christoph Hellwig wrote: > vfs_path_lookup is only used to lookup mount points. So drop the dentry > parameter that is always set to mnt->mnt_root, remove the unused export > and rename the function to mount_path_lookup. NAK. It's a general-purpose API and simplifications are not worth bothering with.