From: Al Viro <viro@zeniv.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/4] fs: pass a nameidata into filename_lookup
Date: Sat, 26 Sep 2020 15:49:02 +0100 [thread overview]
Message-ID: <20200926144902.GZ3421308@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200926092051.115577-4-hch@lst.de>
On Sat, Sep 26, 2020 at 11:20:50AM +0200, Christoph Hellwig wrote:
> This allows keeping the LOOKUP_ROOT case for vfs_path_lookup entirely
> out of the normal fast path.
... saving you all of a if (unlikely(root)) {....} on it. Not worth
it, and
> + struct nameidata nd;
> +
> + return filename_lookup(AT_FDCWD, getname_kernel(name), flags, path,
> + &nd);
is something I would rather avoid on the general principles - better have
set_nameidata()/restore_nameidata() done always to a local variable. Makes
for somewhat easier analysis.
IOW, NAK
next prev parent reply other threads:[~2020-09-26 14:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 9:20 small pathname lookup cleanups Christoph Hellwig
2020-09-26 9:20 ` [PATCH 1/4] fs: remove the unused fs_lookup_param function Christoph Hellwig
2020-09-26 14:57 ` Al Viro
2020-09-26 9:20 ` [PATCH 2/4] fs: mark filename_lookup static Christoph Hellwig
2020-09-26 9:20 ` [PATCH 3/4] fs: pass a nameidata into filename_lookup Christoph Hellwig
2020-09-26 14:49 ` Al Viro [this message]
2020-09-26 9:20 ` [PATCH 4/4] fs: simplify vfs_path_lookup Christoph Hellwig
2020-09-26 14:46 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200926144902.GZ3421308@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).