From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99511C4346E for ; Sun, 27 Sep 2020 12:04:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 581D72389F for ; Sun, 27 Sep 2020 12:04:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="hgvjEqJF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726280AbgI0MEk (ORCPT ); Sun, 27 Sep 2020 08:04:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726252AbgI0MEk (ORCPT ); Sun, 27 Sep 2020 08:04:40 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17479C0613CE; Sun, 27 Sep 2020 05:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3yHqJ6vX2gxZUI8YCJ4GLsFUiXcWJYaONkJBncby4OY=; b=hgvjEqJFSzls9uiRaGd3elF1vz ORkDAJ+4oo6pKY3abbi3iBss7hjm69lSgbiBbowMZHn4khUyoTXfNHhNCW0T0Qg3GDkHMWh1qnZP1 IrslSTktukBAtx73dlx7FW/0TMGcndQLtl5MbZfIqyOdxjmycRi0RX0iajVEzcYux2oUHrViKz6XC 0bM3kFsD85m0U6OVAgEl63w+Ep9vxs0oEyKqDgFA/PT0rp13X1U5V0tysrICh1ErkqD1iKG2aJ8fL 9yRsYWGo9688wdXLnPt4vqWvKM7RApQARixu3g4l2S1kwEgelJUJB6qQC+MSvYFq9u8YXciAQYvjN Vn7k06/A==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMVPv-0007N1-Vw; Sun, 27 Sep 2020 12:04:36 +0000 Date: Sun, 27 Sep 2020 13:04:35 +0100 From: Matthew Wilcox To: Sedat Dilek Cc: Qian Cai , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J. Wong" , Christoph Hellwig , Brian Foster Subject: Re: [PATCH] iomap: Set all uptodate bits for an Uptodate page Message-ID: <20200927120435.GC7714@casper.infradead.org> References: <20200924200225.GC32101@casper.infradead.org> <20200924235756.GD32101@casper.infradead.org> <20200925134608.GE32101@casper.infradead.org> <20200925155340.GG32101@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sun, Sep 27, 2020 at 01:31:15PM +0200, Sedat Dilek wrote: > > I would suggest that you try applying just the assertion to Linus' > > kernel, then try to make it fire. Then apply the fix and see if you > > can still make the assertion fire. > > > > FWIW, I got it to fire with generic/095 from the xfstests test suite. > > With... > > Linux v5.9-rc6+ up to commit a1bf fa48 745a ("Merge tag 'scsi-fixes' > of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi") > ...and... > > xfstests-dev up to commit 75bd80f900ea ("src/t_mmap_dio: do not build > if !HAVE_AIO") > > ...I have seen in my first run of... > > [ generic/095 ] > > dileks@iniza:~/src/xfstests-dev/git$ sudo ./check generic/095 > FSTYP -- ext4 There's the first problem in your setup; you need to be checking XFS to see this problem. ext4 doesn't use iomap for buffered IO yet. > PLATFORM -- Linux/x86_64 iniza 5.9.0-rc6-7-amd64-clang-cfi > #7~bullseye+dileks1 SMP 2020- > 09-27 > MKFS_OPTIONS -- /dev/sdb1 I'm using "-m reflink=1,rmapbt=1 -i sparse=1 -b size=1024"