From: Eric Biggers <ebiggers@kernel.org>
To: Qian Cai <cai@redhat.com>
Cc: David Howells <dhowells@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pipe: Fix memory leaks in create_pipe_files()
Date: Wed, 30 Sep 2020 20:04:25 -0700 [thread overview]
Message-ID: <20201001030425.GA238305@sol.localdomain> (raw)
In-Reply-To: <20201001025255.29560-1-cai@redhat.com>
On Wed, Sep 30, 2020 at 10:52:55PM -0400, Qian Cai wrote:
> diff --git a/include/linux/watch_queue.h b/include/linux/watch_queue.h
> index 5e08db2adc31..20665fbe0552 100644
> --- a/include/linux/watch_queue.h
> +++ b/include/linux/watch_queue.h
> @@ -123,5 +123,9 @@ static inline void remove_watch_list(struct watch_list *wlist, u64 id)
> #define watch_sizeof(STRUCT) (sizeof(STRUCT) << WATCH_INFO_LENGTH__SHIFT)
>
> #endif
> +static inline int watch_queue_init(struct pipe_inode_info *pipe)
> +{
> + return -ENOPKG;
> +}
This needs to be conditional on !CONFIG_WATCH_QUEUE.
- Eric
next prev parent reply other threads:[~2020-10-01 3:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 2:52 [PATCH v2] pipe: Fix memory leaks in create_pipe_files() Qian Cai
2020-10-01 3:04 ` Eric Biggers [this message]
2020-10-01 7:03 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001030425.GA238305@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=cai@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).