From: Al Viro <viro@zeniv.linux.org.uk>
To: Qian Cai <cai@redhat.com>
Cc: David Howells <dhowells@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] pipe: Fix memory leaks in create_pipe_files()
Date: Thu, 1 Oct 2020 14:43:17 +0100 [thread overview]
Message-ID: <20201001134317.GF3421308@ZenIV.linux.org.uk> (raw)
In-Reply-To: <68ab61d0ba3a6ddd7838bc293c9e24f5d8002e27.camel@redhat.com>
On Thu, Oct 01, 2020 at 09:37:02AM -0400, Qian Cai wrote:
> > Fixed by providing a dummy wath_queue_init() in !CONFIG_WATCH_QUEUE
watch_queue_init(), that is
> > case and by having failures of wath_queue_init() handled the same way
ditto
> > we handle alloc_file_pseudo() ones.
> >
> > Fixes: c73be61cede5 ("pipe: Add general notification queue support")
> > Signed-off-by: Qian Cai <cai@redhat.com>
> > =======================
>
> Thanks Al. This looks very good to me.
Applied with that commit message (and typos above corrected) to #fixes
and pushed
prev parent reply other threads:[~2020-10-01 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 12:50 [PATCH v3] pipe: Fix memory leaks in create_pipe_files() Qian Cai
2020-10-01 13:16 ` Al Viro
2020-10-01 13:37 ` Qian Cai
2020-10-01 13:43 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001134317.GF3421308@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=cai@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox