From: kernel test robot <lkp@intel.com>
To: Qian Cai <cai@redhat.com>, David Howells <dhowells@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: kbuild-all@lists.01.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pipe: Fix memory leaks in create_pipe_files()
Date: Thu, 1 Oct 2020 15:03:16 +0800 [thread overview]
Message-ID: <202010011406.KXUVyfIu-lkp@intel.com> (raw)
In-Reply-To: <20201001025255.29560-1-cai@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 3180 bytes --]
Hi Qian,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.9-rc7 next-20200930]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Qian-Cai/pipe-Fix-memory-leaks-in-create_pipe_files/20201001-105501
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 60e720931556fc1034d0981460164dcf02697679
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/40f946bea0970bf1dfa7a9f020e9ad7ec9f1f67d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Qian-Cai/pipe-Fix-memory-leaks-in-create_pipe_files/20201001-105501
git checkout 40f946bea0970bf1dfa7a9f020e9ad7ec9f1f67d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from kernel/watch_queue.c:27:
>> include/linux/watch_queue.h:126:19: error: static declaration of 'watch_queue_init' follows non-static declaration
126 | static inline int watch_queue_init(struct pipe_inode_info *pipe)
| ^~~~~~~~~~~~~~~~
include/linux/watch_queue.h:91:12: note: previous declaration of 'watch_queue_init' was here
91 | extern int watch_queue_init(struct pipe_inode_info *);
| ^~~~~~~~~~~~~~~~
kernel/watch_queue.c:648:5: error: redefinition of 'watch_queue_init'
648 | int watch_queue_init(struct pipe_inode_info *pipe)
| ^~~~~~~~~~~~~~~~
In file included from kernel/watch_queue.c:27:
include/linux/watch_queue.h:126:19: note: previous definition of 'watch_queue_init' was here
126 | static inline int watch_queue_init(struct pipe_inode_info *pipe)
| ^~~~~~~~~~~~~~~~
--
In file included from fs/pipe.c:27:
>> include/linux/watch_queue.h:126:19: error: static declaration of 'watch_queue_init' follows non-static declaration
126 | static inline int watch_queue_init(struct pipe_inode_info *pipe)
| ^~~~~~~~~~~~~~~~
include/linux/watch_queue.h:91:12: note: previous declaration of 'watch_queue_init' was here
91 | extern int watch_queue_init(struct pipe_inode_info *);
| ^~~~~~~~~~~~~~~~
vim +/watch_queue_init +126 include/linux/watch_queue.h
124
125 #endif
> 126 static inline int watch_queue_init(struct pipe_inode_info *pipe)
127 {
128 return -ENOPKG;
129 }
130
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65044 bytes --]
prev parent reply other threads:[~2020-10-01 7:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 2:52 [PATCH v2] pipe: Fix memory leaks in create_pipe_files() Qian Cai
2020-10-01 3:04 ` Eric Biggers
2020-10-01 7:03 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010011406.KXUVyfIu-lkp@intel.com \
--to=lkp@intel.com \
--cc=cai@redhat.com \
--cc=dhowells@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).