From: Jerome Glisse <jglisse@redhat.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Tejun Heo <tj@kernel.org>, Jan Kara <jack@suse.cz>,
Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH 00/14] Small step toward KSM for file back page.
Date: Wed, 7 Oct 2020 10:48:35 -0400 [thread overview]
Message-ID: <20201007144835.GA3471400@redhat.com> (raw)
In-Reply-To: <20201007032013.GS20115@casper.infradead.org>
On Wed, Oct 07, 2020 at 04:20:13AM +0100, Matthew Wilcox wrote:
> On Tue, Oct 06, 2020 at 09:05:49PM -0400, jglisse@redhat.com wrote:
> > The present patchset just add mapping argument to the various vfs call-
> > backs. It does not make use of that new parameter to avoid regression.
> > I am posting this whole things as small contain patchset as it is rather
> > big and i would like to make progress step by step.
>
> Well, that's the problem. This patch set is gigantic and unreviewable.
> And it has no benefits. The idea you present here was discussed at
> LSFMM in Utah and I recall absolutely nobody being in favour of it.
> You claim many wonderful features will be unlocked by this, but I think
> they can all be achieved without doing any of this very disruptive work.
You have any ideas on how to achieve them without such change ? I will
be more than happy for a simpler solution but i fail to see how you can
work around the need for a pointer inside struct page. Given struct
page can not grow it means you need to be able to overload one of the
existing field, at least i do not see any otherway.
Cheers,
Jérôme
next prev parent reply other threads:[~2020-10-07 14:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 1:05 [PATCH 00/14] Small step toward KSM for file back page jglisse
2020-10-07 1:05 ` [PATCH 01/14] mm/pxa: page exclusive access add header file for all helpers jglisse
2020-10-07 1:05 ` [PATCH 02/14] fs: define filler_t as a function pointer type jglisse
2020-10-07 1:05 ` [PATCH 03/14] fs: directly use a_ops->freepage() instead of a local copy of it jglisse
2020-10-07 1:05 ` [PATCH 04/14] mm: add struct address_space to readpage() callback jglisse
2020-10-07 1:05 ` [PATCH 05/14] mm: add struct address_space to writepage() callback jglisse
2020-10-07 1:05 ` [PATCH 06/14] mm: add struct address_space to set_page_dirty() callback jglisse
2020-10-07 1:05 ` [PATCH 07/14] mm: add struct address_space to invalidatepage() callback jglisse
2020-10-07 1:05 ` [PATCH 08/14] mm: add struct address_space to releasepage() callback jglisse
2020-10-07 1:05 ` [PATCH 09/14] mm: add struct address_space to freepage() callback jglisse
2020-10-07 1:05 ` [PATCH 10/14] mm: add struct address_space to putback_page() callback jglisse
2020-10-07 1:06 ` [PATCH 11/14] mm: add struct address_space to launder_page() callback jglisse
2020-10-07 1:06 ` [PATCH 12/14] mm: add struct address_space to is_partially_uptodate() callback jglisse
2020-10-07 1:06 ` [PATCH 13/14] mm: add struct address_space to isolate_page() callback jglisse
2020-10-07 1:06 ` [PATCH 14/14] mm: add struct address_space to is_dirty_writeback() callback jglisse
2020-10-07 3:20 ` [PATCH 00/14] Small step toward KSM for file back page Matthew Wilcox
2020-10-07 14:48 ` Jerome Glisse [this message]
2020-10-07 17:05 ` Matthew Wilcox
2020-10-07 17:54 ` Jerome Glisse
2020-10-07 18:33 ` Matthew Wilcox
2020-10-07 21:45 ` Jerome Glisse
2020-10-07 22:09 ` Matthew Wilcox
2020-10-08 15:30 ` Jerome Glisse
2020-10-08 15:43 ` Matthew Wilcox
2020-10-08 18:48 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007144835.GA3471400@redhat.com \
--to=jglisse@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).