linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: viro@zeniv.linux.org.uk, jack@suse.cz,
	linux-fsdevel@vger.kernel.org, kernel@collabora.com,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: [RESEND^2 PATCH v3 0/3] Clean up and fix error handling in DIO
Date: Thu, 8 Oct 2020 11:32:13 +0200	[thread overview]
Message-ID: <20201008093213.GB3486@quack2.suse.cz> (raw)
In-Reply-To: <20201008062620.2928326-1-krisman@collabora.com>

On Thu 08-10-20 02:26:17, Gabriel Krisman Bertazi wrote:
> Hi,
> 
> Given the proximity of the merge window and since I haven't seen it pop
> up in any of the trees, and considering it is reviewed and fixes a bug
> for us, I'm trying another resend for this so it can get picked up in
> time for 5.10.
> 
> Jan, thanks again for the review and sorry for the noise but is there
> any one else that should be looking at this?

If you can't catch attention of Al Viro, then Jens Axboe is sometimes
merging direct IO fixes as well through his tree. Added to CC. If that
doesn't work out, I can also take the changes through my tree and send them
to Linus in a separate pull request...

								Honza

> Original cover letter:
> 
> This is v3 of Unaligned DIO read error path fix and clean ups.  This
> version applies some small fixes to patch 1 suggested by Jan Kara (thank
> you!)  and it was tested with xfstests aio group over f2fs and fio
> workloads.
> 
> Archive:
>   v1: https://lkml.org/lkml/2020/9/14/915
>   v2: https://www.spinics.net/lists/linux-fsdevel/msg177220.html
>   v3: https://www.spinics.net/lists/linux-fsdevel/msg177310.html
> 
> Gabriel Krisman Bertazi (3):
>   direct-io: clean up error paths of do_blockdev_direct_IO
>   direct-io: don't force writeback for reads beyond EOF
>   direct-io: defer alignment check until after the EOF check
> 
>  fs/direct-io.c | 69 ++++++++++++++++++++++----------------------------
>  1 file changed, 30 insertions(+), 39 deletions(-)
> 
> -- 
> 2.28.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  parent reply	other threads:[~2020-10-08  9:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08  6:26 [RESEND^2 PATCH v3 0/3] Clean up and fix error handling in DIO Gabriel Krisman Bertazi
2020-10-08  6:26 ` [RESEND^2 PATCH 1/3] direct-io: clean up error paths of do_blockdev_direct_IO Gabriel Krisman Bertazi
2020-10-08  6:26 ` [RESEND^2 PATCH 2/3] direct-io: don't force writeback for reads beyond EOF Gabriel Krisman Bertazi
2020-10-08  6:26 ` [RESEND^2 PATCH 3/3] direct-io: defer alignment check until after the EOF check Gabriel Krisman Bertazi
2020-10-08  9:32 ` Jan Kara [this message]
2020-10-08 16:16   ` [RESEND^2 PATCH v3 0/3] Clean up and fix error handling in DIO Jens Axboe
2020-10-08 16:27     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201008093213.GB3486@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=axboe@kernel.dk \
    --cc=kernel@collabora.com \
    --cc=krisman@collabora.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).