From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7468DC433DF for ; Thu, 15 Oct 2020 17:56:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D3292225E for ; Thu, 15 Oct 2020 17:56:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731510AbgJOR4V (ORCPT ); Thu, 15 Oct 2020 13:56:21 -0400 Received: from verein.lst.de ([213.95.11.211]:32878 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731485AbgJOR4T (ORCPT ); Thu, 15 Oct 2020 13:56:19 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 14ED368B02; Thu, 15 Oct 2020 19:56:17 +0200 (CEST) Date: Thu, 15 Oct 2020 19:56:16 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Al Viro , Christoph Hellwig , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 01/13] fs: Allow a NULL pos pointer to __kernel_write Message-ID: <20201015175616.GA23287@lst.de> References: <20201003025534.21045-1-willy@infradead.org> <20201003025534.21045-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201003025534.21045-2-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, Oct 03, 2020 at 03:55:22AM +0100, Matthew Wilcox (Oracle) wrote: > Linus prefers that callers be allowed to pass in a NULL pointer for ppos > like new_sync_write(). > > Signed-off-by: Matthew Wilcox (Oracle) Looks good: Reviewed-by: Christoph Hellwig