From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@linux-foundation.org, Takashi Iwai <tiwai@suse.de>,
dwysocha@redhat.com, linux-afs@lists.infradead.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cachefiles: Drop superfluous readpages aops NULL check
Date: Mon, 19 Oct 2020 16:05:37 +0100 [thread overview]
Message-ID: <20201019150537.GS20115@casper.infradead.org> (raw)
In-Reply-To: <160311941493.2265023.9116264838885193100.stgit@warthog.procyon.org.uk>
On Mon, Oct 19, 2020 at 03:56:54PM +0100, David Howells wrote:
> From: Takashi Iwai <tiwai@suse.de>
>
> After the recent actions to convert readpages aops to readahead, the
> NULL checks of readpages aops in cachefiles_read_or_alloc_page() may
> hit falsely. More badly, it's an ASSERT() call, and this panics.
>
> Drop the superfluous NULL checks for fixing this regression.
>
> [DH: Note that cachefiles never actually used readpages, so this check was
> never actually necessary]
>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=208883
> BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1175245
> Fixes: 9ae326a69004 ("CacheFiles: A cache that backs onto a mounted filesystem")
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: Matthew Wilcox (Oracle) <willy@infradead.org>
next prev parent reply other threads:[~2020-10-19 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 14:56 [PATCH] cachefiles: Drop superfluous readpages aops NULL check David Howells
2020-10-19 15:05 ` Matthew Wilcox [this message]
2020-10-20 7:53 ` Christoph Hellwig
2020-10-20 11:06 ` Matthew Wilcox
2021-01-20 16:12 ` David Howells
-- strict thread matches above, loose matches on Subject: below --
2021-01-20 16:11 David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019150537.GS20115@casper.infradead.org \
--to=willy@infradead.org \
--cc=dhowells@redhat.com \
--cc=dwysocha@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).