From: Matthew Wilcox <willy@infradead.org>
To: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Splitting a THP beyond EOF
Date: Tue, 20 Oct 2020 02:43:57 +0100 [thread overview]
Message-ID: <20201020014357.GW20115@casper.infradead.org> (raw)
This is a weird one ... which is good because it means the obvious
ones have been fixed and now I'm just tripping over the weird cases.
And fortunately, xfstests exercises the weird cases.
1. The file is 0x3d000 bytes long.
2. A readahead allocates an order-2 THP for 0x3c000-0x3ffff
3. We simulate a read error for 0x3c000-0x3cfff
4. Userspace writes to 0x3d697 to 0x3dfaa
5. iomap_write_begin() gets the 0x3c page, sees it's THP and !Uptodate
so it calls iomap_split_page() (passing page 0x3d)
6. iomap_split_page() calls split_huge_page()
7. split_huge_page() sees that page 0x3d is beyond EOF, so it removes it
from i_pages
8. iomap_write_actor() copies the data into page 0x3d
9. The write is lost.
Trying to persuade XFS to update i_size before calling
iomap_file_buffered_write() seems like a bad idea.
Changing split_huge_page() to disregard i_size() is something I kind
of want to be able to do long-term in order to make hole-punch more
efficient, but that seems like a lot of work right now.
I think the easiest way to fix this is to decline to allocate readahead
pages beyond EOF. That is, if we have a file which is, say, 61 pages
long, read the last 5 pages into an order-2 THP and an order-0 THP
instead of allocating an order-3 THP and zeroing the last three pages.
It's probably the right thing to do anyway -- we split THPs that overlap
the EOF on a truncate. I'll start implementing this in the morning,
but I thought I'd share the problem & proposed solution in case anybody
has a better idea.
next reply other threads:[~2020-10-20 1:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 1:43 Matthew Wilcox [this message]
2020-10-20 4:59 ` Splitting a THP beyond EOF Dave Chinner
2020-10-20 11:21 ` Matthew Wilcox
2020-10-20 21:16 ` Dave Chinner
2020-10-20 22:53 ` Matthew Wilcox
2020-10-21 22:14 ` Dave Chinner
2020-10-21 23:04 ` Matthew Wilcox
2020-10-27 5:31 ` Dave Chinner
2020-10-27 12:14 ` Matthew Wilcox
2020-10-20 14:26 ` Matthew Wilcox
2020-10-20 14:32 ` Chris Mason
2020-10-21 0:23 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020014357.GW20115@casper.infradead.org \
--to=willy@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).