From: Christoph Hellwig <hch@infradead.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Vincent Guittot <vincent.guittot@linaro.org>,
anmar.oueja@linaro.org, Arnd Bergmann <arnd@arndb.de>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] dcookies: Make dcookies depend on CONFIG_OPROFILE
Date: Tue, 27 Oct 2020 08:51:52 +0000 [thread overview]
Message-ID: <20201027085152.GB10053@infradead.org> (raw)
In-Reply-To: <51a9a594a38ae6e0982e78976cf046fb55b63a8e.1603191669.git.viresh.kumar@linaro.org>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Is it time to deprecate and eventually remove oprofile while we're at
it?
On Tue, Oct 20, 2020 at 04:31:27PM +0530, Viresh Kumar wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The dcookies stuff is used only with OPROFILE and there is no need to
> build it if CONFIG_OPROFILE isn't enabled. Build it depending on
> CONFIG_OPROFILE instead of CONFIG_PROFILING.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> [ Viresh: Update the name in #endif part ]
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> fs/Makefile | 2 +-
> include/linux/dcookies.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/Makefile b/fs/Makefile
> index 7bb2a05fda1f..a7b3d9ff8db5 100644
> --- a/fs/Makefile
> +++ b/fs/Makefile
> @@ -64,7 +64,7 @@ obj-$(CONFIG_SYSFS) += sysfs/
> obj-$(CONFIG_CONFIGFS_FS) += configfs/
> obj-y += devpts/
>
> -obj-$(CONFIG_PROFILING) += dcookies.o
> +obj-$(CONFIG_OPROFILE) += dcookies.o
> obj-$(CONFIG_DLM) += dlm/
>
> # Do not add any filesystems before this line
> diff --git a/include/linux/dcookies.h b/include/linux/dcookies.h
> index ddfdac20cad0..8617c1871398 100644
> --- a/include/linux/dcookies.h
> +++ b/include/linux/dcookies.h
> @@ -11,7 +11,7 @@
> #define DCOOKIES_H
>
>
> -#ifdef CONFIG_PROFILING
> +#ifdef CONFIG_OPROFILE
>
> #include <linux/dcache.h>
> #include <linux/types.h>
> @@ -64,6 +64,6 @@ static inline int get_dcookie(const struct path *path, unsigned long *cookie)
> return -ENOSYS;
> }
>
> -#endif /* CONFIG_PROFILING */
> +#endif /* CONFIG_OPROFILE */
>
> #endif /* DCOOKIES_H */
> --
> 2.25.0.rc1.19.g042ed3e048af
>
---end quoted text---
next prev parent reply other threads:[~2020-10-27 8:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 11:01 [PATCH] dcookies: Make dcookies depend on CONFIG_OPROFILE Viresh Kumar
2020-10-27 8:51 ` Christoph Hellwig [this message]
2020-10-27 16:54 ` Linus Torvalds
2020-10-28 16:34 ` William Cohen
2020-10-28 18:01 ` Arnd Bergmann
2020-12-17 21:15 ` Linus Torvalds
2020-11-24 6:33 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027085152.GB10053@infradead.org \
--to=hch@infradead.org \
--cc=anmar.oueja@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).