From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] proc: wire up generic_file_splice_read for iter ops
Date: Thu, 29 Oct 2020 11:09:49 +0100 [thread overview]
Message-ID: <20201029100950.46668-3-hch@lst.de> (raw)
In-Reply-To: <20201029100950.46668-1-hch@lst.de>
Wire up generic_file_splice_read for the iter based proxy ops, so
that splice reads from them work.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/proc/inode.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/proc/inode.c b/fs/proc/inode.c
index 58c075e2a452d6..bde6b6f69852d2 100644
--- a/fs/proc/inode.c
+++ b/fs/proc/inode.c
@@ -597,6 +597,7 @@ static const struct file_operations proc_iter_file_ops = {
.llseek = proc_reg_llseek,
.read_iter = proc_reg_read_iter,
.write = proc_reg_write,
+ .splice_read = generic_file_splice_read,
.poll = proc_reg_poll,
.unlocked_ioctl = proc_reg_unlocked_ioctl,
.mmap = proc_reg_mmap,
@@ -622,6 +623,7 @@ static const struct file_operations proc_reg_file_ops_compat = {
static const struct file_operations proc_iter_file_ops_compat = {
.llseek = proc_reg_llseek,
.read_iter = proc_reg_read_iter,
+ .splice_read = generic_file_splice_read,
.write = proc_reg_write,
.poll = proc_reg_poll,
.unlocked_ioctl = proc_reg_unlocked_ioctl,
--
2.28.0
next prev parent reply other threads:[~2020-10-29 10:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 10:09 support splice reads on seq_file based procfs files Christoph Hellwig
2020-10-29 10:09 ` [PATCH 1/3] seq_file: add seq_read_iter Christoph Hellwig
2020-10-29 10:32 ` Greg KH
2020-10-29 10:09 ` Christoph Hellwig [this message]
2020-10-29 10:32 ` [PATCH 2/3] proc: wire up generic_file_splice_read for iter ops Greg KH
2020-10-29 10:09 ` [PATCH 3/3] proc: switch over direct seq_read method calls to seq_read_iter Christoph Hellwig
2020-10-29 10:32 ` Greg KH
2020-11-03 18:48 ` support splice reads on seq_file based procfs files Christoph Hellwig
2020-11-03 18:57 ` Linus Torvalds
2020-11-03 19:02 ` Christoph Hellwig
2020-11-03 19:07 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029100950.46668-3-hch@lst.de \
--to=hch@lst.de \
--cc=adobriyan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).