From: Al Viro <viro@zeniv.linux.org.uk>
To: Jens Axboe <axboe@kernel.dk>
Cc: Qian Cai <cai@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths
Date: Fri, 30 Oct 2020 22:22:13 +0000 [thread overview]
Message-ID: <20201030222213.GR3576660@ZenIV.linux.org.uk> (raw)
In-Reply-To: <d858ba48-624f-43be-93cf-07d94f0ebefd@kernel.dk>
On Fri, Oct 30, 2020 at 02:33:11PM -0600, Jens Axboe wrote:
> On 10/30/20 12:49 PM, Al Viro wrote:
> > On Fri, Oct 30, 2020 at 12:46:26PM -0600, Jens Axboe wrote:
> >
> >> See other reply, it's being posted soon, just haven't gotten there yet
> >> and it wasn't ready.
> >>
> >> It's a prep patch so we can call do_renameat2 and pass in a filename
> >> instead. The intent is not to have any functional changes in that prep
> >> patch. But once we can pass in filenames instead of user pointers, it's
> >> usable from io_uring.
> >
> > You do realize that pathname resolution is *NOT* offloadable to helper
> > threads, I hope...
>
> How so? If we have all the necessary context assigned, what's preventing
> it from working?
Semantics of /proc/self/..., for starters (and things like /proc/mounts, etc.
*do* pass through that, /dev/stdin included)
next prev parent reply other threads:[~2020-10-30 22:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 15:24 [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths Qian Cai
2020-10-30 15:27 ` Jens Axboe
2020-10-30 15:52 ` Qian Cai
2020-10-30 16:49 ` Jens Axboe
2020-10-30 18:42 ` Al Viro
2020-10-30 18:46 ` Jens Axboe
2020-10-30 18:49 ` Al Viro
2020-10-30 20:33 ` Jens Axboe
2020-10-30 22:22 ` Al Viro [this message]
2020-10-30 23:21 ` Jens Axboe
2020-11-02 18:43 ` Eric W. Biederman
2020-11-02 19:27 ` Eric W. Biederman
2020-11-02 19:54 ` Jens Axboe
2020-11-02 20:12 ` Eric W. Biederman
2020-11-02 20:31 ` Jens Axboe
2020-11-02 21:39 ` Jens Axboe
2020-11-03 14:45 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030222213.GR3576660@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=axboe@kernel.dk \
--cc=cai@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).