From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D511C388F9 for ; Fri, 30 Oct 2020 22:22:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF70120719 for ; Fri, 30 Oct 2020 22:22:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725796AbgJ3WWU (ORCPT ); Fri, 30 Oct 2020 18:22:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbgJ3WWU (ORCPT ); Fri, 30 Oct 2020 18:22:20 -0400 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11769C0613D5; Fri, 30 Oct 2020 15:22:20 -0700 (PDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYcmj-00CJcS-NX; Fri, 30 Oct 2020 22:22:13 +0000 Date: Fri, 30 Oct 2020 22:22:13 +0000 From: Al Viro To: Jens Axboe Cc: Qian Cai , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths Message-ID: <20201030222213.GR3576660@ZenIV.linux.org.uk> References: <20201030152407.43598-1-cai@redhat.com> <20201030184255.GP3576660@ZenIV.linux.org.uk> <20201030184918.GQ3576660@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Oct 30, 2020 at 02:33:11PM -0600, Jens Axboe wrote: > On 10/30/20 12:49 PM, Al Viro wrote: > > On Fri, Oct 30, 2020 at 12:46:26PM -0600, Jens Axboe wrote: > > > >> See other reply, it's being posted soon, just haven't gotten there yet > >> and it wasn't ready. > >> > >> It's a prep patch so we can call do_renameat2 and pass in a filename > >> instead. The intent is not to have any functional changes in that prep > >> patch. But once we can pass in filenames instead of user pointers, it's > >> usable from io_uring. > > > > You do realize that pathname resolution is *NOT* offloadable to helper > > threads, I hope... > > How so? If we have all the necessary context assigned, what's preventing > it from working? Semantics of /proc/self/..., for starters (and things like /proc/mounts, etc. *do* pass through that, /dev/stdin included)