From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 651B4C2D0A3 for ; Sun, 1 Nov 2020 11:20:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29ACD2085B for ; Sun, 1 Nov 2020 11:20:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="XpMCbKkN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726339AbgKALUd (ORCPT ); Sun, 1 Nov 2020 06:20:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726282AbgKALUd (ORCPT ); Sun, 1 Nov 2020 06:20:33 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D1D8C0617A6 for ; Sun, 1 Nov 2020 03:20:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XP0ktuKFVEjKCr/aKj+0RFycxoJenodAvemu+mBbN+s=; b=XpMCbKkNBAQZfANnvHYW4hKUPw X/J3MGVTBbdZqcROukoYfpxTmrR7kuiX5P59xTHonPZvF74HDYypX9hSYOFU4TlSEiqbUc3oOid24 i98Sh0rpgt8FWSSfDExqzbiH0f2erGcyczwY8qHO3tywOPESRYiaCvOFdcJH7m0cCZuMNjtM9votn D3PqVDJCYVARL6WIHFwql1Up4qMLPJEXX4k8eKIWXtW54axHB0roYgd5cxBMnIPekIr1CJiZknhJL dju1Uf1XMNQEcjLX5NRVCm4IKNyqQjYWiRRUAwGnwsOed6/6arUBRsr0vkOCW4cA7Lj6K2dIq16t4 aYPXyzkQ==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZBPR-0003vU-Jq; Sun, 01 Nov 2020 11:20:29 +0000 Date: Sun, 1 Nov 2020 11:20:29 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Andrew Morton , Kent Overstreet , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 10/13] mm: open code readahead in filemap_new_page Message-ID: <20201101112029.GX27442@casper.infradead.org> References: <20201031090004.452516-1-hch@lst.de> <20201031090004.452516-11-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201031090004.452516-11-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, Oct 31, 2020 at 10:00:01AM +0100, Christoph Hellwig wrote: > Calling filemap_make_page_uptodate right after filemap_readpage in > filemap_new_page is rather counterintuitive. The call is in fact > only needed to issue async readahead, and is guaranteed to return > just after that because the page is uptodate. Just open code the > readahead related parts of filemap_make_page_uptodate instead. Oh, you got rid of it again ;-) It's still not possible for this page to have Readahead set on it -- it was only just created, and can't possibly have been created by an earlier readahead call.