From: David Sterba <dsterba@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-fsdevel@vger.kernel.org, David Sterba <dsterba@suse.com>,
Wonhyuk Yang <vvghjk1234@gmail.com>
Subject: Re: [PATCH] mm: Fix readahead_page_batch for retry entries
Date: Wed, 4 Nov 2020 15:27:54 +0100 [thread overview]
Message-ID: <20201104142754.GF6756@suse.cz> (raw)
In-Reply-To: <20201103171054.7d80b3010cac0bee705d0ae7@linux-foundation.org>
On Tue, Nov 03, 2020 at 05:10:54PM -0800, Andrew Morton wrote:
> On Tue, 3 Nov 2020 14:28:52 +0000 "Matthew Wilcox (Oracle)" <willy@infradead.org> wrote:
>
> > Both btrfs and fuse have reported faults caused by seeing a retry
> > entry instead of the page they were looking for. This was caused
> > by a missing check in the iterator.
>
> Ambiguous. What sort of "faults"? Kernel pagefaults which cause
> oopses?
>
> It would be helpful to to provide sufficient info so that a reader of
> this changelog can recognize whether this patch might fix some problem
> which is being observed.
>
> > Reported-by: David Sterba <dsterba@suse.com>
> > Reported-by: Wonhyuk Yang <vvghjk1234@gmail.com>
>
> Perhaps via links to these reports.
Reported by irc/mail, I'll try to dig the stack trace from the logs
again. The crash is hard to hit, there was just one occurence since 5.8
times.
next prev parent reply other threads:[~2020-11-04 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 14:28 [PATCH] mm: Fix readahead_page_batch for retry entries Matthew Wilcox (Oracle)
2020-11-04 1:10 ` Andrew Morton
2020-11-04 14:27 ` David Sterba [this message]
2020-11-05 2:33 ` Wonhyuk Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104142754.GF6756@suse.cz \
--to=dsterba@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=dsterba@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=vvghjk1234@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).