From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5F44C2D0A3 for ; Fri, 6 Nov 2020 08:16:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 720A1208B3 for ; Fri, 6 Nov 2020 08:16:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726027AbgKFIQj (ORCPT ); Fri, 6 Nov 2020 03:16:39 -0500 Received: from verein.lst.de ([213.95.11.211]:50578 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725830AbgKFIQi (ORCPT ); Fri, 6 Nov 2020 03:16:38 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 6A44268B05; Fri, 6 Nov 2020 09:16:36 +0100 (CET) Date: Fri, 6 Nov 2020 09:16:36 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, kent.overstreet@gmail.com Subject: Re: [PATCH v2 13/18] mm/filemap: Add filemap_range_uptodate Message-ID: <20201106081636.GG31585@lst.de> References: <20201104204219.23810-1-willy@infradead.org> <20201104204219.23810-14-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201104204219.23810-14-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org > + if (mapping->host->i_blkbits >= (PAGE_SHIFT + thp_order(page))) > + return false; > + > + pos = (loff_t) page->index << PAGE_SHIFT; Should this use page_offset() ? Otherwise looks good: Reviewed-by: Christoph Hellwig