From: Al Viro <viro@zeniv.linux.org.uk>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Greg KH <gregkh@linuxfoundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, wei.liu@kernel.org,
linux-hyperv@vger.kernel.org
Subject: Re: [PATCH 1/6] seq_file: add seq_read_iter
Date: Sat, 14 Nov 2020 01:17:54 +0000 [thread overview]
Message-ID: <20201114011754.GL3576660@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20201113235453.GA227700@ubuntu-m3-large-x86>
On Fri, Nov 13, 2020 at 04:54:53PM -0700, Nathan Chancellor wrote:
> This patch in -next (6a9f696d1627bacc91d1cebcfb177f474484e8ba) breaks
> WSL2's interoperability feature, where Windows paths automatically get
> added to PATH on start up so that Windows binaries can be accessed from
> within Linux (such as clip.exe to pipe output to the clipboard). Before,
> I would see a bunch of Linux + Windows folders in $PATH but after, I
> only see the Linux folders (I can give you the actual PATH value if you
> care but it is really long).
>
> I am not at all familiar with the semantics of this patch or how
> Microsoft would be using it to inject folders into PATH (they have some
> documentation on it here:
> https://docs.microsoft.com/en-us/windows/wsl/interop) and I am not sure
> how to go about figuring that out to see why this patch breaks something
> (unless you have an idea). I have added the Hyper-V maintainers and list
> to CC in case they know someone who could help.
Out of curiosity: could you slap WARN_ON(!iov_iter_count(iter)); right in
the beginning of seq_read_iter() and see if that triggers?
next prev parent reply other threads:[~2020-11-14 1:18 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 8:27 support splice reads on seq_file based procfs files v2 Christoph Hellwig
2020-11-04 8:27 ` [PATCH 1/6] seq_file: add seq_read_iter Christoph Hellwig
2020-11-10 21:32 ` Al Viro
2020-11-10 21:35 ` Al Viro
2020-11-10 23:20 ` Al Viro
2020-11-11 7:55 ` Christoph Hellwig
2020-11-11 17:54 ` Linus Torvalds
2020-11-11 21:52 ` Al Viro
2020-11-11 22:21 ` Al Viro
2020-11-11 22:27 ` Linus Torvalds
2020-11-11 23:00 ` Al Viro
2020-11-13 23:54 ` Nathan Chancellor
2020-11-14 1:17 ` Al Viro [this message]
2020-11-14 3:01 ` Nathan Chancellor
2020-11-14 3:54 ` Al Viro
2020-11-14 4:14 ` Nathan Chancellor
2020-11-14 5:50 ` Al Viro
2020-11-14 6:19 ` Nathan Chancellor
2020-11-14 7:00 ` Al Viro
2020-11-14 20:50 ` Al Viro
2020-11-15 15:53 ` Al Viro
2020-11-15 16:56 ` Linus Torvalds
2020-11-15 21:41 ` Nathan Chancellor
2020-11-15 23:38 ` Al Viro
2020-11-15 23:51 ` Nathan Chancellor
2020-11-16 0:25 ` Al Viro
2020-11-16 0:34 ` Nathan Chancellor
2020-11-16 3:29 ` Al Viro
2020-11-27 16:29 ` Christoph Hellwig
2020-12-08 16:35 ` Christoph Hellwig
2020-12-08 18:34 ` Linus Torvalds
2020-12-08 19:49 ` Al Viro
2020-12-08 20:25 ` Linus Torvalds
2020-12-08 20:53 ` Al Viro
2020-12-08 21:01 ` Linus Torvalds
2020-12-08 19:49 ` Greg KH
2020-11-14 21:44 ` Al Viro
2020-11-04 8:27 ` [PATCH 2/6] proc: wire up generic_file_splice_read for iter ops Christoph Hellwig
2020-11-04 8:27 ` [PATCH 3/6] proc/cpuinfo: switch to ->read_iter Christoph Hellwig
2020-11-04 8:27 ` [PATCH 4/6] proc/stat: " Christoph Hellwig
2020-11-04 8:27 ` [PATCH 5/6] proc "single files": " Christoph Hellwig
2020-11-04 8:27 ` [PATCH 6/6] proc "seq " Christoph Hellwig
2020-11-04 17:53 ` support splice reads on seq_file based procfs files v2 Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201114011754.GL3576660@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=adobriyan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=hch@lst.de \
--cc=kys@microsoft.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=sthemmin@microsoft.com \
--cc=torvalds@linux-foundation.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).