From: Matthew Wilcox <willy@infradead.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: David Laight <David.Laight@aculab.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Soheil Hassas Yeganeh <soheil.kdev@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Shuo Chen <shuochen@google.com>
Subject: Re: [PATCH v2] epoll: add nsec timeout support
Date: Mon, 16 Nov 2020 20:00:09 +0000 [thread overview]
Message-ID: <20201116200009.GJ29991@casper.infradead.org> (raw)
In-Reply-To: <CAF=yD-LGtfPGuqM8WP5Wz7d9_u6x-HdeBitKg81zdA8E6tMQwQ@mail.gmail.com>
On Mon, Nov 16, 2020 at 02:54:17PM -0500, Willem de Bruijn wrote:
> > You could also add a compile assert to check that the flag is reserved.
>
> Like this?
>
> /* Check the EPOLL_* constant for consistency. */
> BUILD_BUG_ON(EPOLL_CLOEXEC != O_CLOEXEC);
> + BUILD_BUG_ON(EPOLL_NSTIMEO & EPOLL_RESERVED_FLAGS);
i think you got the sense of that test wrong. but yes.
next prev parent reply other threads:[~2020-11-16 20:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 16:10 [PATCH v2] epoll: add nsec timeout support Willem de Bruijn
2020-11-16 16:12 ` Soheil Hassas Yeganeh
2020-11-16 16:19 ` Matthew Wilcox
2020-11-16 17:00 ` Willem de Bruijn
2020-11-16 17:11 ` David Laight
2020-11-16 19:54 ` Willem de Bruijn
2020-11-16 20:00 ` Matthew Wilcox [this message]
2020-11-16 20:04 ` Andrew Morton
2020-11-16 23:36 ` Willem de Bruijn
2020-11-16 23:51 ` Willem de Bruijn
2020-11-17 0:37 ` Andrew Morton
2020-11-17 2:21 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116200009.GJ29991@casper.infradead.org \
--to=willy@infradead.org \
--cc=David.Laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuochen@google.com \
--cc=soheil.kdev@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox