Re: [PATCH RFC] iomap: only return IO error if no data has been transferred

Dave Chinner
2020-11-18T22:21:43Z

On Wed, Nov 18, 2020 at 02:55:06PM -0700, Jens Axboe wrote:
> On 11/18/20 2:48 PM, Dave Chinner wrote:
> > On Wed, Nov 18, 2020 at 02:36:47PM -0700, Jens Axboe wrote:
> >> On 11/18/20 2:33 PM, Dave Chinner wrote:
> >>> On Wed, Nov 18, 2020 at 02:19:30PM -0700, Jens Axboe wrote:
> >>>>>>> Can you provide an actual event trace of the IOs in question that
> >>>>>>> are failing in your tests (e.g. from something like `trace-cmd
> >>>>>>> record -e xfs_file\* -e xfs_i\* -e xfs_\*write -e iomap\*` over the
> >>>>>>> sequential that reproduces the issue) so that there's no ambiguity
> >>>>>>> over how this problem is occurring in your systems?
> >>>>>>
> >>>>>> Let me know if you still want this!
> >>>>>
> >>>>> No, it makes sense now :)
> >>>>
> >>>> What's the next step here? Are you working on an XFS fix for this?
> >>>
> >>> I'm just building the patch now for testing.
> >>
> >> Nice, you're fast...
> >
> > Only when I understand exactly what is happening :/
>
> That certainly helps...
>
> > Patch below.
>
> Thanks, ran it through the test case 20 times (would always fail before
> in one run), and no issues observed.
>
> Tested-by: Jens Axboe <axboe@kernel.dk>

Thanks. It's running through fstests right now, once that's done
I'll repost it for review/inclusion in a new thread.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com