linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: XiaoLi Feng <xifeng@redhat.com>
To: linux-fsdevel@vger.kernel.org, david@fromorbit.com,
	darrick.wong@oracle.com
Cc: Xiaoli Feng <fengxiaoli0714@gmail.com>
Subject: [PATCH v2] fs/stat: set attributes_mask for STATX_ATTR_DAX
Date: Wed, 25 Nov 2020 10:08:40 +0800	[thread overview]
Message-ID: <20201125020840.1275-1-xifeng@redhat.com> (raw)

From: Xiaoli Feng <fengxiaoli0714@gmail.com>

keep attributes and attributes_mask are consistent for
STATX_ATTR_DAX.
---
Hi,
Please help to review this patch. I send this patch because xfstests generic/532
is failed for dax test.

 fs/stat.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/stat.c b/fs/stat.c
index dacecdda2e79..4619b3fc9694 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -80,8 +80,10 @@ int vfs_getattr_nosec(const struct path *path, struct kstat *stat,
 	if (IS_AUTOMOUNT(inode))
 		stat->attributes |= STATX_ATTR_AUTOMOUNT;
 
-	if (IS_DAX(inode))
+	if (IS_DAX(inode)) {
 		stat->attributes |= STATX_ATTR_DAX;
+		stat->attributes_mask |= STATX_ATTR_DAX;
+	}
 
 	if (inode->i_op->getattr)
 		return inode->i_op->getattr(path, stat, request_mask,
-- 
2.18.1


             reply	other threads:[~2020-11-25  2:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25  2:08 XiaoLi Feng [this message]
2020-11-25  2:46 ` [PATCH v2] fs/stat: set attributes_mask for STATX_ATTR_DAX Darrick J. Wong
2020-11-25  5:53   ` Xiaoli Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201125020840.1275-1-xifeng@redhat.com \
    --to=xifeng@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=fengxiaoli0714@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).