From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F4DC63777 for ; Thu, 26 Nov 2020 09:15:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69E0320DD4 for ; Thu, 26 Nov 2020 09:15:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389173AbgKZJPl (ORCPT ); Thu, 26 Nov 2020 04:15:41 -0500 Received: from verein.lst.de ([213.95.11.211]:33584 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389172AbgKZJPl (ORCPT ); Thu, 26 Nov 2020 04:15:41 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id B4FAE68BEB; Thu, 26 Nov 2020 10:15:37 +0100 (CET) Date: Thu, 26 Nov 2020 10:15:37 +0100 From: Christoph Hellwig To: Yicong Yang Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, prime.zeng@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH] fs: export vfs_stat() and vfs_fstatat() Message-ID: <20201126091537.GA21957@lst.de> References: <1606374948-38713-1-git-send-email-yangyicong@hisilicon.com> <20201126071848.GA17990@lst.de> <696f0e06-4f4d-0a61-6e13-f5af433594bf@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <696f0e06-4f4d-0a61-6e13-f5af433594bf@hisilicon.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Nov 26, 2020 at 05:08:26PM +0800, Yicong Yang wrote: > > And why would you want to use them in kernel module? Please explain > > that in the patch that exports them, and please send that patch in the > > same series as the patches adding the users. > > we're using it in the modules for testing our crypto driver on our CI system. > is it mandatory to upstream it if we want to use this function? Yes. And chances are that you do not actaully need these functions either, but to suggest a better placement I need to actually see the code.