From: Oleg Nesterov <oleg@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Wen Yang <wenyang@linux.alibaba.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Christian Brauner <christian@brauner.io>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] proc: add locking checks in proc_inode_is_dead
Date: Tue, 1 Dec 2020 13:35:56 +0100 [thread overview]
Message-ID: <20201201123556.GB2700@redhat.com> (raw)
In-Reply-To: <87zh2yit5u.fsf@x220.int.ebiederm.org>
On 11/30, Eric W. Biederman wrote:
>
> Ouch!!!! Oleg I just looked the introduction of proc_inode_is_dead in
> d855a4b79f49 ("proc: don't (ab)use ->group_leader in proc_task_readdir()
> paths") introduced a ``regression''.
>
> Breaking the logic introduced in 7d8952440f40 ("[PATCH] procfs: Fix
> listing of /proc/NOT_A_TGID/task") to keep those directory listings not
> showing up.
Sorry, I don't understand...
Do you mean that "ls /proc/pid/task" can see an empty dir? Afaics this
was possible before d855a4b79f49 too.
Or what?
Oleg.
next prev parent reply other threads:[~2020-12-01 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 17:58 [PATCH] proc: add locking checks in proc_inode_is_dead Wen Yang
2020-11-28 19:01 ` Oleg Nesterov
2020-11-30 18:41 ` Eric W. Biederman
2020-12-01 12:35 ` Oleg Nesterov [this message]
2020-12-01 15:06 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201123556.GB2700@redhat.com \
--to=oleg@redhat.com \
--cc=adobriyan@gmail.com \
--cc=christian@brauner.io \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wenyang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).