From: Amir Goldstein <amir73il@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org
Subject: [PATCH 0/7] fsnotify fixes and cleanups
Date: Wed, 2 Dec 2020 14:07:06 +0200 [thread overview]
Message-ID: <20201202120713.702387-1-amir73il@gmail.com> (raw)
Jan,
I was working on some non urgent cleanups and stumbled on a bug,
so flushing my patch queue as is.
Patches 1-2 are cleanups needed for the bug fix in patch 3.
This [1] LTP test demonstrates the bug.
Patches 4-5 are pretty simple cleanups that you may or may not like
to apply without the work that they build up to (I started this as
prep work for subtree marks iterator).
Patches 6-7 are optimizations related to ignored mask which we
discussed in the past. I have written them a while back and had put
them aside because I have no means to run performance tests that will
demonstrate the benefit, which is probably not huge.
Since you suggested those optimizations (at least the first one),
I decided to post and let you choose what to do with them.
Thanks,
Amir.
[1] https://github.com/amir73il/ltp/commits/fsnotify-fixes
Amir Goldstein (7):
fsnotify: generalize handle_inode_event()
inotify: convert to handle_inode_event() interface
fsnotify: fix events reported to watching parent and child
fsnotify: clarify object type argument
fsnotify: separate mark iterator type from object type enum
fsnotify: optimize FS_MODIFY events with no ignored masks
fsnotify: optimize merging of marks with no ignored masks
fs/nfsd/filecache.c | 2 +-
fs/notify/dnotify/dnotify.c | 2 +-
fs/notify/fanotify/fanotify.c | 16 +--
fs/notify/fanotify/fanotify_user.c | 44 +++++---
fs/notify/fsnotify.c | 147 +++++++++++++++++----------
fs/notify/group.c | 2 +-
fs/notify/inotify/inotify.h | 9 +-
fs/notify/inotify/inotify_fsnotify.c | 47 ++-------
fs/notify/inotify/inotify_user.c | 7 +-
fs/notify/mark.c | 30 +++---
include/linux/fsnotify_backend.h | 92 +++++++++++------
kernel/audit_fsnotify.c | 2 +-
kernel/audit_tree.c | 2 +-
kernel/audit_watch.c | 2 +-
14 files changed, 233 insertions(+), 171 deletions(-)
--
2.25.1
next reply other threads:[~2020-12-02 12:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 12:07 Amir Goldstein [this message]
2020-12-02 12:07 ` [PATCH 1/7] fsnotify: generalize handle_inode_event() Amir Goldstein
2020-12-03 9:51 ` Jan Kara
2020-12-03 10:41 ` Amir Goldstein
2020-12-03 12:02 ` Jan Kara
2020-12-02 12:07 ` [PATCH 2/7] inotify: convert to handle_inode_event() interface Amir Goldstein
2020-12-03 9:55 ` Jan Kara
2020-12-03 10:45 ` Amir Goldstein
2020-12-03 12:37 ` Jan Kara
2020-12-03 12:43 ` Amir Goldstein
2020-12-02 12:07 ` [PATCH 3/7] fsnotify: fix events reported to watching parent and child Amir Goldstein
2020-12-03 11:53 ` Jan Kara
2020-12-03 12:58 ` Amir Goldstein
2020-12-03 14:24 ` Jan Kara
2020-12-02 12:07 ` [PATCH 4/7] fsnotify: clarify object type argument Amir Goldstein
2020-12-02 12:07 ` [PATCH 5/7] fsnotify: separate mark iterator type from object type enum Amir Goldstein
2020-12-02 12:07 ` [PATCH 6/7] fsnotify: optimize FS_MODIFY events with no ignored masks Amir Goldstein
2020-12-02 12:07 ` [PATCH 7/7] fsnotify: optimize merging of marks " Amir Goldstein
2020-12-03 10:35 ` Jan Kara
2020-12-03 10:56 ` Amir Goldstein
2020-12-03 14:52 ` [PATCH 0/7] fsnotify fixes and cleanups Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202120713.702387-1-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).