From: Jens Axboe <axboe@kernel.dk>
To: linux-fsdevel@vger.kernel.org
Cc: torvalds@linux-foundation.org, viro@zeniv.linux.org.uk
Subject: [PATCHSET RFC v2 0/5] fs: Support for LOOKUP_NONBLOCK / RESOLVE_NONBLOCK
Date: Sat, 12 Dec 2020 09:51:00 -0700 [thread overview]
Message-ID: <20201212165105.902688-1-axboe@kernel.dk> (raw)
Hi,
After the discussion yesterday, I reworked some of the bits since the v1
posting:
- Improved the 1/5 cleanup patch, based on Al's feedback.
- 2/5 is much cleaner now, also based on Al's feedback. For later
patches, we also need the same LOOKUP_NONBLOCK failure case in
unlazy_child(), so I added that. Also fixed the LOOKUP_NONBLOCK
check in path_init().
- Add mnt_want_write_trylock(). Since we already have
sb_start_write_trylock(), this is pretty trivial.
- Add 4/5 which handles LOOKUP_NONBLOCK for open_last_lookups(),
do_open(), and do_tmpfile(). O_TRUNC is expressly not allowed
with LOOKUP_NONBLOCK/RESOLVE_NONBLOCK, so I didn't want to
attempt to wire up nonblocking semantics there.
- Fixed comment in 5/5, and added the O_TRUNC check there too. No
further changes there. I'll commit to writing the change for the
openat2(2) man page as well, as well as some test cases, once we make
some more progress on the kernel side.
Ran this through some basic testing with both io_uring (that patch
I left out of this series) and openat2(), and works for me...
--
Jens Axboe
next reply other threads:[~2020-12-12 16:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-12 16:51 Jens Axboe [this message]
2020-12-12 16:51 ` [PATCH 1/5] fs: make unlazy_walk() error handling consistent Jens Axboe
2020-12-12 16:51 ` [PATCH 2/5] fs: add support for LOOKUP_NONBLOCK Jens Axboe
2020-12-12 16:51 ` [PATCH 3/5] fs: add mnt_want_write_trylock() Jens Axboe
2020-12-12 16:51 ` [PATCH 4/5] fs: honor LOOKUP_NONBLOCK for the last part of file open Jens Axboe
2020-12-12 17:25 ` Al Viro
2020-12-12 17:47 ` Jens Axboe
2020-12-12 18:57 ` Linus Torvalds
2020-12-12 21:25 ` Jens Axboe
2020-12-12 22:03 ` Linus Torvalds
2020-12-13 22:50 ` Dave Chinner
2020-12-14 0:45 ` Linus Torvalds
2020-12-14 1:52 ` Dave Chinner
2020-12-14 18:06 ` Linus Torvalds
2020-12-14 17:43 ` Jens Axboe
2020-12-12 16:51 ` [PATCH 5/5] fs: expose LOOKUP_NONBLOCK through openat2() RESOLVE_NONBLOCK Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201212165105.902688-1-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).