From: Matthew Wilcox <willy@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Mike Marshall <hubcap@omnibond.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Mike Marshall <hubcapsc@gmail.com>
Subject: Re: "do_copy_range:: Invalid argument"
Date: Mon, 14 Dec 2020 04:07:03 +0000 [thread overview]
Message-ID: <20201214040703.GJ2443@casper.infradead.org> (raw)
In-Reply-To: <20201214030552.GI3913616@dread.disaster.area>
On Mon, Dec 14, 2020 at 02:05:52PM +1100, Dave Chinner wrote:
> On Fri, Dec 11, 2020 at 11:26:28AM -0500, Mike Marshall wrote:
> > Greetings everyone...
> >
> > Omnibond has sent me off doing some testing chores lately.
> > I made no Orangefs patches for 5.9 or 5.10 and none were sent,
> > but I thought I should at least run through xfstests.
> >
> > There are tests that fail on 5.10-rc6 that didn't fail
> > on 5.8-rc7, and I've done enough looking to see that the
> > failure reasons all seem related.
> >
> > I will, of course, keep looking to try and understand these
> > failures. Bisection might lead me somewhere. In case the
> > notes I've taken so far trigger any of y'all to give me
> > any (constructive :-) ) suggestions, I've included them below.
> >
> > -Mike
> >
> > ---------------------------------------------------------------------
> >
> > generic/075
> > 58rc7: ? (check.log says it ran, results file missing)
> > 510rc6: failed, "do_copy_range:: Invalid argument"
> > read the tests/generic/075 commit message for "detect
> > preallocation support for fsx tests"
> >
> > generic/091
> > 58rc7: passed, but skipped fallocate parts "filesystem does not support"
> > 510rc6: failed, "do_copy_range:: Invalid argument"
> >
> > generic/112
> > 58rc7: ? (check.log says it ran, results file missing)
> > 510rc6: failed, "do_copy_range:: Invalid argument"
> >
> > generic/127
> > 58rc7: ? (check.log says it ran, results file missing)
> > 510rc6: failed, "do_copy_range:: Invalid argument"
> >
> > generic/249
> > 58rc7: passed
> > 510rc6: failed, "sendfile: Invalid argument"
> > man 2 sendfile -> "SEE ALSO copy_file_range(2)"
>
> If sendfile() failed, then it's likely a splice related regression,
> not a copy_file_range() problem. The VFS CFR implementation falls
> back to splice if the fs doesn't provide a clone or copy offload
> method.
>
> THere's only been a handful of changes to fs/splice.c since 5.8rc7,
> so it might be worth doing a quick check reverting them first...
I'd suggest applying the equivalent of
https://lore.kernel.org/linux-fsdevel/1606837496-21717-1-git-send-email-asmadeus@codewreck.org/
would be the first step.
next prev parent reply other threads:[~2020-12-14 4:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 16:26 "do_copy_range:: Invalid argument" Mike Marshall
2020-12-14 3:05 ` Dave Chinner
2020-12-14 4:07 ` Matthew Wilcox [this message]
2020-12-15 20:20 ` Mike Marshall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214040703.GJ2443@casper.infradead.org \
--to=willy@infradead.org \
--cc=david@fromorbit.com \
--cc=hubcap@omnibond.com \
--cc=hubcapsc@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).